More flexible division for BoxedUint#1181
Open
andrewwhitehead wants to merge 6 commits intoRustCrypto:masterfrom
Open
More flexible division for BoxedUint#1181andrewwhitehead wants to merge 6 commits intoRustCrypto:masterfrom
BoxedUint#1181andrewwhitehead wants to merge 6 commits intoRustCrypto:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
+ Coverage 86.72% 87.12% +0.40%
==========================================
Files 182 182
Lines 20390 20492 +102
==========================================
+ Hits 17683 17854 +171
+ Misses 2707 2638 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
upd/boxed-div
branch
from
ec92fe0 to
e6b3ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1149
This PR also introduces a
ToUnsignedtrait which helps converting from a&NonZero<T>to an ownedUnsignedinstance.RemMixedis also implemented unconditionally forUintrather than being implemented through a macro for specific sizes.