Add ConstantTimeSelect trait
#454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't impl `subtle::ConditionallySelectable` for `Boxed*` types due to a bound on `Copy`. I've proposed various ways to try to fix this upstream, e.g. dalek-cryptography/subtle#118, from which the `ConstantTimeSelect` trait has been extracted. It provides the same API as `ConditionallySelectable` but without the `Copy` bound. A blanket impl of `ConstantTimeSelect` for all `ConditionallySelectable` types means that all stack allocated types can continue to use `ConditionallySelectable` and will receive an impl of `ConstantTimeSelect` as well. A bound on `ConstantTimeSelect` has been added to the `Integer` trait as well, allowing it to be used on all `*Uint` types in this crate with `Integer` as the trait abstraction.
|
This of course doesn't work with the |
|
Merging this so we have some sort of trait-based abstraction over these types |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't impl
subtle::ConditionallySelectableforBoxed*types due to a bound onCopy.I've proposed various ways to try to fix this upstream, e.g. dalek-cryptography/subtle#118, from which the
ConstantTimeSelecttrait has been extracted. It provides the same API asConditionallySelectablebut without theCopybound.A blanket impl of
ConstantTimeSelectfor allConditionallySelectabletypes means that all stack allocated types can continue to useConditionallySelectableand will receive an impl ofConstantTimeSelectas well.A bound on
ConstantTimeSelecthas been added to theIntegertrait as well, allowing it to be used on all*Uinttypes in this crate withIntegeras the trait abstraction.