Skip to content

Conversation

baloo
Copy link
Member

@baloo baloo commented Jul 18, 2025

This is used in x448 (#1250)

@baloo baloo force-pushed the baloo/ed448-goldilocks/export-curvewithscalar branch from 8b9ed18 to 5e75386 Compare July 18, 2025 20:26
@baloo baloo mentioned this pull request Jul 19, 2025
Copy link
Contributor

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build x448 without exposing CurveWithScalar.
Why was this necessary on your end?

@baloo
Copy link
Member Author

baloo commented Jul 19, 2025

I think it built, but it was not exposed in the doc, which made it harder to reason about.
This might not be necessary now we have the MontgomeryXpoint

@daxpedda
Copy link
Contributor

My intention actually was to hide them from the docs.
All the methods provided by this trait are re-exposed on the Scalar directly.

If you think there is still an issue in the docs, let me know in detail as I would like to take a look at it.

I'm still playing with the alternative to turn scalar.rs into a huge macro so the scalars can become types instead of typedef's ... but maybe we can find another alternative.

@baloo baloo closed this Jul 19, 2025
@baloo baloo deleted the baloo/ed448-goldilocks/export-curvewithscalar branch July 19, 2025 20:28
@baloo
Copy link
Member Author

baloo commented Jul 19, 2025

Yeah you're correct, it was not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants