Merged
Conversation
It was noted as buggy in #1319 because `shr` was being computed on values within the Montgomery domain directly. They either need to be converted to canonical form first, or a multiplication needs to be used in place of a bit shift. Turns out it was completely unused, aside from fulfilling a bound in the `elliptic-curve` crate, which has since been removed. This removes `shr` support from all curves whose `Scalar` used an internal Montgomery representation. It has been retained on `k256` and `p256` which use canonical form `Scalar` types. Closes #1319
tarcieri
force-pushed
the
primefield/remove-shr-support
branch
from
c4cebd1 to
e780294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was noted as buggy in #1319 because
shrwas being computed on values within the Montgomery domain directly. They either need to be converted to canonical form first, or a Montgomery multiplication needs to be used in place of a bit shift.Turns out it was completely unused, aside from fulfilling a bound in the
elliptic-curvecrate, which has since been removed.This removes
shrsupport from all curves whoseScalaruses an internal Montgomery representation. It has been retained onk256andp256which use canonical formScalartypes.Closes #1319