-
Notifications
You must be signed in to change notification settings - Fork 236
sm2: pke no std support #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
sm2: pke no std support #1325
Conversation
sm2/src/dsa.rs
Outdated
#[cfg(feature = "pkcs8")] | ||
#[cfg(all(feature = "alloc", feature = "pkcs8"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you changing this? Everything but SignatureBitStringEncoding
is available in no-alloc
environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you resolve this comment without answering or changing anything?
@tarcieri I'm sorry, I've replied, but it seems that you can't see it over there These imports are only used in elliptic-curves/sm2/src/dsa.rs Lines 208 to 232 in 20eeeff
|
Oh, your comment is marked pending. I’m on a phone but I’m confused why there wouldn’t be unused import warnings in thar case. |
The current main branch uses std by default |
By "default" in the sense of a default-enabled https://github.com/RustCrypto/elliptic-curves/blob/8f6a343/sm2/Cargo.toml#L38-L40 |
Sorry I didn't know this, but now I've changed it back |
add sm2 pke no std support
ref #1099