Make ProjectiveNielsPoint::identity() an associated constant
#1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
changed the title
ProjectiveNielsPoint::identity() and associated constantProjectiveNielsPoint::identity() an associated constant
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
ProjectiveNielsPoint::identity()and associated constantIDENTITY.This actually had quite the effect on Edwards scalar multiplication, it called the twisted-curve to Niel's form conversion 113 times during the operation which isn't being optimized away in release mode (with fat LTO,
codegen-units = 1and such). So during each iteration this added 3 multiplications to the already 20 present, a flat 15% increase. Which approximately matches the benchmarks I've run.Also affects Decaf scalar multiplication with #1303.