Skip to content

hash2curve: Error rework #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Aug 12, 2025
Merged

hash2curve: Error rework #1338

merged 40 commits into from
Aug 12, 2025

Conversation

carloskiki
Copy link
Contributor

Discussed in #1295. This was planned as a follow up to #1317, but I decided to make it as its own PR because #1317 is not unanimous.

Replaces elliptic_curve::{Error, Result} with an associated type on ExpandMsg.

daxpedda
daxpedda suggested changes Jul 31, 2025
View reviewed changes
daxpedda
daxpedda suggested changes Aug 2, 2025
View reviewed changes
daxpedda
daxpedda suggested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just documentation nits at this point.
Otherwise LGTM!

carloskiki and others added 10 commits August 7, 2025 09:39
@carloskiki @daxpedda
Update hash2curve/src/hash2field/expand_msg/xmd.rs
9bb1690 
Co-authored-by: daxpedda <[email protected]>
@carloskiki @daxpedda
Update hash2curve/src/hash2field/expand_msg/xmd.rs
1cff5b6 
Co-authored-by: daxpedda <[email protected]>
@carloskiki @daxpedda
Update hash2curve/src/hash2field/expand_msg/xmd.rs
e84f772 
Co-authored-by: daxpedda <[email protected]>
@carloskiki @daxpedda
Update hash2curve/src/hash2field/expand_msg/xmd.rs
54c1faa 
Co-authored-by: daxpedda <[email protected]>
@carloskiki @daxpedda
Update hash2curve/src/hash2field/expand_msg/xof.rs
919fbd4 
Co-authored-by: daxpedda <[email protected]>
@carloskiki @daxpedda
Update hash2curve/src/hash2field/expand_msg/xof.rs
a895b78 
Co-authored-by: daxpedda <[email protected]>
@carloskiki @daxpedda
Update hash2curve/src/group_digest.rs
0a3b2cc 
Co-authored-by: daxpedda <[email protected]>
@carloskiki
replace qualifed path with use
f917470
@carloskiki
Add docs for len_in_bytes in hash_to_field
09bc9ff
@carloskiki
chore: fmt
2b42323
daxpedda
daxpedda suggested changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don't know what RustCrypto's stance is on custom error types is in general, but I think this is a good idea. Otherwise we should at least extract the compile-time error cases as I believe those are a great improvement.

@tarcieri tarcieri merged commit e73bccf into RustCrypto:master Aug 12, 2025
88 checks passed
@carloskiki carloskiki deleted the errors branch September 1, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

+1 more reviewer

@daxpedda daxpedda daxpedda approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carloskiki @tarcieri @daxpedda