Skip to content

ed448-goldilocks: reject identity points in Group::try_from_rng() #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025
Merged

ed448-goldilocks: reject identity points in Group::try_from_rng() #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ed448-goldilocks/src/decaf/points.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,11 @@ impl Group for DecafPoint {
let mut bytes = DecafPointRepr::default();

loop {
rng.try_fill_bytes(bytes.as_mut())?;
if let Some(point) = Self::from_bytes(&bytes).into() {
rng.try_fill_bytes(&mut bytes)?;
if let Some(point) = Self::from_bytes(&bytes)
.into_option()
.filter(|&point| point != Self::IDENTITY)
{
return Ok(point);
}
}
Expand Down
7 changes: 5 additions & 2 deletions ed448-goldilocks/src/edwards/extended.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,8 +344,11 @@ impl Group for EdwardsPoint {
let mut bytes = Array::default();

loop {
rng.try_fill_bytes(bytes.as_mut())?;
if let Some(point) = Self::from_bytes(&bytes).into() {
rng.try_fill_bytes(&mut bytes)?;
if let Some(point) = Self::from_bytes(&bytes)
.into_option()
.filter(|&point| point != Self::IDENTITY)
{
return Ok(point);
}
}
Expand Down