[WIP] Test ECDSA implementation for Brainpool curves #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishmaker
reviewed
Aug 4, 2025
| pub type Signature = ecdsa::Signature<BrainpoolP256r1>; | ||
|
|
||
| /// ECDSA/brainpoolP256r1 signature (ASN.1 DER encoded) | ||
| /// ECDSA/Brainpool-256r1 signature (ASN.1 DER encoded) |
There was a problem hiding this comment.
Thanks for the tests. However, why change the name to Brainpool-256r1?
There was a problem hiding this comment.
no specific reason, I just haven’t cleaned it up yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the
p256crate I started expanding on the ECDSA implementation for the brainpool curvesTODOs
bp256r1bp384r1