Skip to content

x448: api fixups #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

x448: api fixups #1374

merged 2 commits into from
Aug 21, 2025

Conversation

baloo
Copy link
Member

@baloo baloo commented Aug 21, 2025

This is a followup to #1250

tarcieri
tarcieri approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a start, though it would probably be good to have separate StaticSecret and EphemeralSecret types, where the latter provides no access to the inner secret key, only its public key and the ability to do Diffie-Hellman

@tarcieri tarcieri merged commit 19962f7 into RustCrypto:master Aug 21, 2025
18 checks passed
@baloo baloo deleted the baloo/x448/fixups branch August 21, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baloo @tarcieri