ed448-goldilocks: merge Scalar types#1471
Open
daxpedda wants to merge 1 commit intoRustCrypto:masterfrom
Open
Conversation
daxpedda
force-pushed
the
ed448-scalar-merge
branch
from
5452d46 to
e865426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See explanation in #1464. This doesn't change the serialization format of
EdwardsPoint, which is still 57 bytes.Notably, this properly adjusts
Ed448::FieldBytesSizeto 56 bytes as well. E.g. the affine coordinates now also return 56 bytes instead of falsely 57 bytes.Reverts #1284.
Resolves #1464.
Replaces #1463.