fix: align bignp256 pkcs8 feature gating#1655
Open
Forostovec wants to merge 3 commits intoRustCrypto:masterfrom
Open
fix: align bignp256 pkcs8 feature gating#1655Forostovec wants to merge 3 commits intoRustCrypto:masterfrom
Forostovec wants to merge 3 commits intoRustCrypto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed inconsistent pkcs8 integration in bignp256 where pkcs8-dependent code in secret_key/public_key was compiled unconditionally while the pkcs8 dependency itself is optional. This could break builds when only arithmetic is enabled or when pem was enabled without the crate-level pkcs8 feature.