rand_core: upcoming API breaks #2175
Merged
+68
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in the upcoming rand_core 0.10.0-rc-4 dropped the implied `CryptoRng: RngCore` from the trait. This forces any consumer to make the requirement explicit. This commit prepares for that.
Member
Author
|
I might make a release of pkcs5 for that, that would ease things up on the RSA side. |
Member
|
@baloo please wait until I do https://github.com/RustCrypto/password-hashes |
Member
Author
|
Sure, I'm not sure I understand the dependency graph, but I'm happy to wait before merging. |
Member
|
It seems to be fine, I guess you can go ahead (though I'm surprised you're not hitting issues with |
Member
Author
|
I haven't bumped rand_core yet, I'm still locked on |
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jan 20, 2026
This reverts commit 08b22e5. Those changes are no longer necessary after fixes made in rand_core 0.10.0-rc-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in the upcoming rand_core 0.10.0-rc-4 dropped the implied
CryptoRng: RngCorefrom the trait. This forces any consumer to make the requirement explicit. This commit prepares for that.