chacha20 - Returning serde feature along with a compile time warning?
#498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion here (rust-random/rand#1101) I have added a warning whenever
serdeis enabled. This assumes that people will read compile-time warnings. I have verified that the warning shows up on dependent crates, but I will add that if the dependency is too far upstream, people might not know whether the warning is something to be worried about, so some game devs might raise an issue about why they keep getting this warning. We could add a feature callednon_crypto_PRNGor something similar to silence the warning. Just want to show what the changes would look like if we added the feature back and added a simple warning.