digest: remove AssociatedOid blanket impls for wrappers
#1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems like you could completely remove the The trait impl is easy enough to write by hand |
Member
Author
|
I would love to do it, but we still have the |
Member
|
Missed RustCrypto/hashes#678 |
This was referenced May 12, 2025
baloo
added a commit
to baloo/traits
that referenced
this pull request
May 25, 2025
…stCrypto#1810)" This reverts commit c48ea2a.
baloo
added a commit
to baloo/traits
that referenced
this pull request
May 25, 2025
…stCrypto#1810)" This reverts commit c48ea2a.
tarcieri
pushed a commit
that referenced
this pull request
May 25, 2025
) This reverts commit c48ea2a (#1810) This bring back `master` in a state that can be consumed with a `[patch.crates-io]` (see #1799 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #1799 users would need to implement
AssociatedOidmanually on created newtypes.Also replaces
feature = "const-oid"withfeature = "oid"in some places.