Bump rand_core to v0.10.0-rc-4
#2195
Merged
+31
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the changes are backwards compatible with every crate except for `elliptic-curve`, where some reborrowing was required
Member
Author
Member
|
huum, no there is something fishy here, you shouldn't have to do that. |
Member
|
I think this is because I've opened #2197 to remove the extraneous references |
tarcieri
pushed a commit
that referenced
this pull request
Jan 19, 2026
This fixes changes made in #2195 This is due to the refactor made in rand_core in rust-random/rand_core#45 which dropped the "trait dependency" between CryptoRng and RngCore
1 task
It very much should do. If it doesn't that's a bug. (I know the traits are written differently, but as best I can tell this is still implied.) |
newpavlov
reviewed
Jan 20, 2026
| Self { | ||
| scalar, | ||
| mask: Scalar::<C>::random(rng), | ||
| mask: Scalar::<C>::random(&mut rng), |
Member
There was a problem hiding this comment.
Why not keep Scalar::<C>::random(rng)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the changes are backwards compatible with every crate except for
elliptic-curve, where some reborrowing was required