workspace: avoid duplicate crypto-common definition when using git dependencies #2198
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/push-pkuxvrmopmnu
branch
from
05c8a1c to
059ba53
Compare
newpavlov
reviewed
Jan 19, 2026
…pendency When consuming an master release with `[patch.crates-io]` crypto-common would get duplicated because of the `path = "../` in each crate. This moves the override to the workspace `Cargo.toml` and remove that duplicate crypto-common crate instance.
baloo
force-pushed
the
baloo/push-pkuxvrmopmnu
branch
from
059ba53 to
bc830cc
Compare
baloo
changed the title
newpavlov
approved these changes
Jan 19, 2026
Member
|
Agree with @newpavlov's suggestion |
Member
Author
|
That's fixed right? |
tarcieri
approved these changes
Jan 19, 2026
Member
|
Yep, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consuming an master release with
[patch.crates-io]crypto-common would get duplicated because of thepath = "../in each crate.This moves the override to the workspace
Cargo.tomland remove that duplicate crypto-common crate instance.