block-padding: remove unsafe usage
#1224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spot checking this for RustCrypto/hybrid-array#148 |
Pushes the unsafety down to the `hybrid-array` level, using the newly added `Array::slice_as_flattened`. Also adds `forbid(unsafe_code)`.
tarcieri
force-pushed
the
block-padding/remove-unsafe-usage
branch
from
3b89259 to
7084f59
Compare
|
@newpavlov updated to use |
tarcieri
commented
Sep 23, 2025
Comment on lines
+83
to
+84
| // Note: `res_len` is always smaller or equal to `bs * blocks.len()` | ||
| Ok(&Array::slice_as_flattened(blocks)[..res_len]) |
There was a problem hiding this comment.
Perhaps we could do something like this instead?
Suggested change
| // Note: `res_len` is always smaller or equal to `bs * blocks.len()` | |
| Ok(&Array::slice_as_flattened(blocks)[..res_len]) | |
| Array::slice_as_flattened(blocks).get(..res_len).ok_or(UnpadError) |
There was a problem hiding this comment.
If res_len is bigger than data.len() than it's a bug, so we should panic.
|
Closing in favor of #1222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes the unsafety down to the
hybrid-arraylevel, using the newly addedArray::slice_as_flattened.Also adds
forbid(unsafe_code).