cmov: mark isize/usize impls of Cmov(Eq) as always available
#1387
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via rustc itself:
expected values for `target_pointer_width` are: `16`, `32`, and `64`
This adds a `doc(cfg(true))` attribute to the impls for `isize` and
`usize` to hide the `cfg` gating so it doesn't show up in the rustdoc,
but it's still retained to the crate compiles if rustc suddenly decides
to add support for e.g. `8` or `128`-bit wide pointers.
tarcieri
added a commit
that referenced
this pull request
Jan 18, 2026
From #1387, via rustc itself: expected values for `target_pointer_width` are: `16`, `32`, and `64` So these impls should actually be ubiquitously available, for now. If we remove the gating in this crate, then all we need to do to handle new pointer widths is ship a fix for `cmov`.
tarcieri
added a commit
that referenced
this pull request
Jan 18, 2026
From #1387, via rustc itself: expected values for `target_pointer_width` are: `16`, `32`, and `64` So these impls should actually be ubiquitously available, for now. If we remove the gating in this crate, then all we need to do to handle new pointer widths is ship a fix for `cmov`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via rustc itself:
This adds a
doc(cfg(true))attribute to the impls forisizeandusizeto hide thecfggating so it doesn't show up in the rustdoc, but it's still retained to the crate compiles if rustc suddenly decides to add support for e.g.8or128-bit wide pointers.