Skip to content

Commit 3b2dc54

Browse files
committed
Move lowercasing of Etag into HTTPResponse
1 parent 550225f commit 3b2dc54

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/java/com/rusticisoftware/tincan/http/HTTPResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public String getContent() {
4646
}
4747

4848
public String getContentType() { return this.getHeader("Content-Type"); }
49-
public String getEtag() { return this.getHeader("ETag"); }
49+
public String getEtag() { return this.getHeader("ETag").toLowerCase(); }
5050
public DateTime getLastModified() {
5151
DateTimeFormatter RFC1123_DATE_TIME_FORMATTER =
5252
DateTimeFormat.forPattern("EEE, dd MMM yyyy HH:mm:ss 'GMT'").withZoneUTC();

src/test/java/com/rusticisoftware/tincan/RemoteLRSTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ public void testRetrieveState() throws Exception {
386386
Assert.assertTrue(save.getSuccess());
387387

388388
StateLRSResponse lrsRes = lrs.retrieveState("test", activity, agent, null);
389-
Assert.assertEquals("\"c140f82cb70e3884ad729b5055b7eaa81c795f1f\"", lrsRes.getContent().getEtag().toLowerCase());
389+
Assert.assertEquals("\"c140f82cb70e3884ad729b5055b7eaa81c795f1f\"", lrsRes.getContent().getEtag());
390390
Assert.assertTrue(lrsRes.getSuccess());
391391
}
392392

@@ -539,7 +539,7 @@ public void testRetrieveActivityProfile() throws Exception {
539539
Assert.assertTrue(save.getSuccess());
540540

541541
ActivityProfileLRSResponse lrsRes = lrs.retrieveActivityProfile("test", activity);
542-
Assert.assertEquals("\"6e6e6c11d7e0bffe0369873a2a5fd751ab2ea64f\"", lrsRes.getContent().getEtag().toLowerCase());
542+
Assert.assertEquals("\"6e6e6c11d7e0bffe0369873a2a5fd751ab2ea64f\"", lrsRes.getContent().getEtag());
543543
Assert.assertTrue(lrsRes.getSuccess());
544544
}
545545

@@ -688,7 +688,7 @@ public void testRetrieveAgentProfile() throws Exception {
688688
Assert.assertTrue(save.getSuccess());
689689

690690
AgentProfileLRSResponse lrsRes = lrs.retrieveAgentProfile("test", agent);
691-
Assert.assertEquals("\"da16d3e0cbd55e0f13558ad0ecfd2605e2238c71\"", lrsRes.getContent().getEtag().toLowerCase());
691+
Assert.assertEquals("\"da16d3e0cbd55e0f13558ad0ecfd2605e2238c71\"", lrsRes.getContent().getEtag());
692692
Assert.assertTrue(lrsRes.getSuccess());
693693
}
694694

0 commit comments

Comments
 (0)