Fix JSX comment duplication in preserve mode

.github/copilot-questions.md

@@ -1,4 +1,5 @@
-Questions I have that I think the developers of this project can help me with:
- * How does control flow analysis represent a circular graph? I checked the documentation server for "cfa" and "control flow"
- * How do I tell if a symbol is in the global scope? I checked the documentation server for topics referencing "symbol" and "global"
- * What is an `EscapedName`, exactly?
+Questions I have that I think the developers of this project can help me with:
+ * How does control flow analysis represent a circular graph? I checked the documentation server for "cfa" and "control flow"
+ * How do I tell if a symbol is in the global scope? I checked the documentation server for topics referencing "symbol" and "global"
+ * What is an `EscapedName`, exactly?
+ * How does TypeScript distinguish between comments inside JSX text vs regular TypeScript comments? I searched for "JSX text comments emitter forEachTrailingCommentRange JSX text ranges" - The issue was that comment iteration doesn't understand JSX context and treats JSX text content as regular comments.

src/compiler/emitter.ts

@@ -1253,6 +1253,8 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
     var detachedCommentsInfo: { nodePos: number; detachedCommentEndPos: number; }[] | undefined;
     var hasWrittenComment = false;
     var commentsDisabled = !!printerOptions.removeComments;
+    // Track JSX text ranges to prevent them from being treated as comments
+    var jsxTextRanges: { start: number; end: number; }[] = [];
     var lastSubstitution: Node | undefined;
     var currentParenthesizerRule: ParenthesizerRule<any> | undefined;
     var { enter: enterComment, exit: exitComment } = performance.createTimerIf(extendedDiagnostics, "commentTime", "beforeComment", "afterComment");
@@ -1387,11 +1389,22 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
         currentSourceFile = sourceFile;
         currentLineMap = undefined;
         detachedCommentsInfo = undefined;
+        jsxTextRanges = []; // Clear JSX text ranges for new source file
+
+        // Pre-collect all JSX text ranges before emission starts
         if (sourceFile) {
+            collectJsxTextRanges(sourceFile);
             setSourceMapSource(sourceFile);
         }
     }
 
+    function collectJsxTextRanges(node: Node) {
+        if (node.kind === SyntaxKind.JsxText) {
+            jsxTextRanges.push({ start: node.pos, end: node.end });
+        }
+        forEachChild(node, collectJsxTextRanges);
+    }
+
     function setWriter(_writer: EmitTextWriter | undefined, _sourceMapGenerator: SourceMapGenerator | undefined) {
         if (_writer && printerOptions.omitTrailingSemicolon) {
             _writer = getTrailingSemicolonDeferringWriter(_writer);
@@ -6096,15 +6109,27 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
                 forEachLeadingCommentWithoutDetachedComments(cb);
             }
             else {
-                forEachLeadingCommentRange(currentSourceFile.text, pos, cb, /*state*/ pos);
+                forEachLeadingCommentRange(currentSourceFile.text, pos, (commentPos, commentEnd, kind, hasTrailingNewLine, rangePos) => {
+                    // Check if this comment position falls within any JSX text range
+                    const isWithinJsxText = jsxTextRanges.some(range => commentPos >= range.start && commentEnd <= range.end);
+                    if (!isWithinJsxText) {
+                        cb(commentPos, commentEnd, kind, hasTrailingNewLine, rangePos);
+                    }
+                }, /*state*/ pos);
             }
         }
     }
 
     function forEachTrailingCommentToEmit(end: number, cb: (commentPos: number, commentEnd: number, kind: SyntaxKind, hasTrailingNewLine: boolean) => void) {
         // Emit the trailing comments only if the container's end doesn't match because the container should take care of emitting these comments
         if (currentSourceFile && (containerEnd === -1 || (end !== containerEnd && end !== declarationListContainerEnd))) {
-            forEachTrailingCommentRange(currentSourceFile.text, end, cb);
+            forEachTrailingCommentRange(currentSourceFile.text, end, (commentPos, commentEnd, kind, hasTrailingNewLine) => {
+                // Check if this comment position falls within any JSX text range
+                const isWithinJsxText = jsxTextRanges.some(range => commentPos >= range.start && commentEnd <= range.end);
+                if (!isWithinJsxText) {
+                    cb(commentPos, commentEnd, kind, hasTrailingNewLine);
+                }
+            });
         }
     }
 
@@ -6123,7 +6148,13 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
             detachedCommentsInfo = undefined;
         }
 
-        forEachLeadingCommentRange(currentSourceFile.text, pos, cb, /*state*/ pos);
+        forEachLeadingCommentRange(currentSourceFile.text, pos, (commentPos, commentEnd, kind, hasTrailingNewLine, rangePos) => {
+            // Check if this comment position falls within any JSX text range
+            const isWithinJsxText = jsxTextRanges.some(range => commentPos >= range.start && commentEnd <= range.end);
+            if (!isWithinJsxText) {
+                cb(commentPos, commentEnd, kind, hasTrailingNewLine, rangePos);
+            }
+        }, /*state*/ pos);
     }
 
     function emitDetachedCommentsAndUpdateCommentsInfo(range: TextRange) {

tests/baselines/reference/jsxCommentDuplication.js

@@ -0,0 +1,9 @@
+//// [tests/cases/compiler/jsxCommentDuplication.tsx] ////
+
+//// [jsxCommentDuplication.tsx]
+function App() {}
+const jsx = <App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App>;
+
+//// [jsxCommentDuplication.jsx]
+function App() { }
+var jsx = <App>/* no */{/* 1 */123 /* 2 */}/* no */</App>;

tests/baselines/reference/jsxCommentDuplication.symbols

@@ -0,0 +1,11 @@
+//// [tests/cases/compiler/jsxCommentDuplication.tsx] ////
+
+=== jsxCommentDuplication.tsx ===
+function App() {}
+>App : Symbol(App, Decl(jsxCommentDuplication.tsx, 0, 0))
+
+const jsx = <App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App>;
+>jsx : Symbol(jsx, Decl(jsxCommentDuplication.tsx, 1, 5))
+>App : Symbol(App, Decl(jsxCommentDuplication.tsx, 0, 0))
+>App : Symbol(App, Decl(jsxCommentDuplication.tsx, 0, 0))
+

tests/baselines/reference/jsxCommentDuplication.types

@@ -0,0 +1,17 @@
+//// [tests/cases/compiler/jsxCommentDuplication.tsx] ////
+
+=== jsxCommentDuplication.tsx ===
+function App() {}
+>App : () => void
+>    : ^^^^^^^^^^
+
+const jsx = <App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App>;
+>jsx : error
+><App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App> : error
+>App : () => void
+>    : ^^^^^^^^^^
+>123 : 123
+>    : ^^^
+>App : () => void
+>    : ^^^^^^^^^^
+

tests/baselines/reference/jsxCommentDuplicationDebug.js

@@ -0,0 +1,9 @@
+//// [tests/cases/compiler/jsxCommentDuplicationDebug.tsx] ////
+
+//// [jsxCommentDuplicationDebug.tsx]
+function App() {}
+const jsx = <App>/* before */{/* 1 */ 123 /* 2 */}/* after */</App>;
+
+//// [jsxCommentDuplicationDebug.jsx]
+function App() { }
+var jsx = <App>/* before */{123}/* after */</App>;

tests/baselines/reference/jsxCommentDuplicationDebug.symbols

@@ -0,0 +1,11 @@
+//// [tests/cases/compiler/jsxCommentDuplicationDebug.tsx] ////
+
+=== jsxCommentDuplicationDebug.tsx ===
+function App() {}
+>App : Symbol(App, Decl(jsxCommentDuplicationDebug.tsx, 0, 0))
+
+const jsx = <App>/* before */{/* 1 */ 123 /* 2 */}/* after */</App>;
+>jsx : Symbol(jsx, Decl(jsxCommentDuplicationDebug.tsx, 1, 5))
+>App : Symbol(App, Decl(jsxCommentDuplicationDebug.tsx, 0, 0))
+>App : Symbol(App, Decl(jsxCommentDuplicationDebug.tsx, 0, 0))
+

tests/baselines/reference/jsxCommentDuplicationDebug.types

@@ -0,0 +1,17 @@
+//// [tests/cases/compiler/jsxCommentDuplicationDebug.tsx] ////
+
+=== jsxCommentDuplicationDebug.tsx ===
+function App() {}
+>App : () => void
+>    : ^^^^^^^^^^
+
+const jsx = <App>/* before */{/* 1 */ 123 /* 2 */}/* after */</App>;
+>jsx : error
+><App>/* before */{/* 1 */ 123 /* 2 */}/* after */</App> : error
+>App : () => void
+>    : ^^^^^^^^^^
+>123 : 123
+>    : ^^^
+>App : () => void
+>    : ^^^^^^^^^^
+

tests/baselines/reference/tsxAttributeResolution14.js

@@ -35,11 +35,8 @@ function VerticalNavMenuItem(prop) {
 }
 function VerticalNav() {
     return (<div>
-      <VerticalNavMenuItem primaryText={2}/> // error
-      // error
-      <VerticalNavMenuItem justRandomProp={2} primaryText={"hello"}/> // ok
-      // ok
-      <VerticalNavMenuItem justRandomProp1={true} primaryText={"hello"}/> // error
-      // error
+      <VerticalNavMenuItem primaryText={2}/>  // error
+      <VerticalNavMenuItem justRandomProp={2} primaryText={"hello"}/>  // ok
+      <VerticalNavMenuItem justRandomProp1={true} primaryText={"hello"}/>  // error
     </div>);
 }

tests/cases/compiler/jsxCommentDuplication.tsx

@@ -0,0 +1,3 @@
+// @jsx: preserve
+function App() {}
+const jsx = <App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App>;