Open
Conversation
The 3.3 testunit CI job was hanging for 6 hours and timing out. Problem: test-unit 3.7.4 changed the TestSuite#run method signature: - 3.7.3: run(result, run_context: nil, &block) - 3.7.4+: run(worker_context, &block) test-queue's TestSuite subclass uses `def run(*); super; end`, which fails on 3.7.3 when test-unit internally calls run with 2 arguments: ArgumentError: wrong number of arguments (given 2, expected 1) The worker process crashes, but the master process keeps waiting indefinitely, causing the hang. Reproduction: Hangs (with test-unit 3.7.3): gem install test-unit -v 3.7.3 BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle exec testunit-queue ./test/examples/*_testunit.rb Works (with test-unit >= 3.7.4): gem install test-unit -v 3.7.5 BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle exec testunit-queue ./test/examples/*_testunit.rb Solution: Pin test-unit to >= 3.7.4 in gemfiles/testunit.gemfile.
Fix testunit CI hang by requiring test-unit >= 3.7.4
Minitest v6 was released on 2025-12-18. see: https://github.com/minitest/minitest/releases/tag/v6.0.0 These changes make test-queue work with Minitest v6.
S-H-GAMELINKS
force-pushed
the
support/minitest6
branch
from
14c44a6 to
8677bdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minitest v6 was released on 2025-12-18.
see: https://github.com/minitest/minitest/releases/tag/v6.0.0
These changes make test-queue work with Minitest v6.