Skip to content

Waveform generator sends a synthetic opt-out message with every admission - #156

Merged
jeremyestein merged 1 commit into
developfrom
jeremy/opt-outs
Feb 18, 2026
Merged

Waveform generator sends a synthetic opt-out message with every admission#156
jeremyestein merged 1 commit into
developfrom
jeremy/opt-outs

Conversation

@jeremyestein

@jeremyestein jeremyestein commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

To test #155 , we need to set up the Emap DB so that some patients have opted out of research.

See SAFEHR-data/waveform-controller#63 for main implementation of the opt-out.

@github-actions

Copy link
Copy Markdown

PR checklist

Default guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)

  • From the UCLH data science desktop, a validation run has been set off
  • Check that content that reveals Epic IP (eg. Clarity/Caboodle queries) has not been checked into a public repo.
  • load times
    in UCL teams has been populated with the run information
  • During the run, glowroot has been checked for any queries which are taking a substantial proportion of the
    total processing time. This can be useful to identify indexes that are required.
  • After the run, look for any unexpected errors in the etl_per_message_logging table, the error_search.sql file
    on the shared drive can be used for this \\sharefs6\UCLH6\EMAP\Shared\EmapSqlScripts\devops\error_search.sql.
    Create an issue if you find an unexpected exception and is not related to the changes you've made, otherwise
    fix them!
  • After the run, populate the end time in
    load times
  • Let Aasiyah know about the completed validation and give her information on the changes and where to start
    with the validation
  • Check validation report and give any feedback to Aasiyah if there are any changes needed on her side,
    iterate on getting the validation to match at least 99% (validation and emap code).

@jeremyestein jeremyestein linked an issue Feb 16, 2026 that may be closed by this pull request
1 task

@skeating skeating left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with this

@jeremyestein
jeremyestein merged commit 533890c into develop Feb 18, 2026
9 checks passed
@jeremyestein
jeremyestein deleted the jeremy/opt-outs branch February 18, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check Patient has not opted out

2 participants