Adds OCR evaluation script / Fixes WER calculation#39
Merged
Conversation
Collaborator
Author
|
TODO: this PR branched off old branch prior to |
Collaborator
Author
|
Re-run analysis today – results more sensible now. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an OCR evaluation script and fixes the WER (Word Error Rate) calculation method. The changes improve the accuracy of text comparison metrics and make the evaluation functionality more modular.
- Replaces Levenshtein string-based WER calculation with a proper word-based dynamic programming implementation
- Refactors OCR evaluation script to be more modular by extracting a
run()function - Adds disk space management to GitHub Actions workflow to handle build requirements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pyonb/analysis/metrics.py | Fixes WER calculation with proper dynamic programming and updates metric documentation |
| src/pyonb/analysis/eval_ocr.py | Refactors evaluation script to be more modular and adds file encoding parameter |
| .github/workflows/tests.yml | Adds disk space cleanup step to prevent build failures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
p-j-smith
reviewed
Oct 6, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
p-j-smith
approved these changes
Oct 6, 2025
Collaborator
p-j-smith
left a comment
There was a problem hiding this comment.
thanks for fixing this @tomaroberts!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: