Conversation
… HOST_DATA_FOLDER to CONTAINER_DATA_FOLDER
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the forwarding API by converting it from a standalone module in src/api to a proper uv workspace package in packages/api. The main purpose is to improve the project structure and package management for the OCR forwarding API component.
- Moved the forwarding API from
src/apitopackages/apias a properuvpackage - Updated Docker configuration to use caching and better build practices
- Removed unused test functions and utility code that are no longer needed
Reviewed Changes
Copilot reviewed 10 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/api/test_app.py | Removed unused imports and data folder validation test function |
| src/api/requirements.txt | Deleted old requirements file (moved to package configuration) |
| src/api/app/util.py | Removed utility functions that are no longer needed |
| src/api/Dockerfile | Deleted old Dockerfile (replaced with new one in packages/api) |
| pyproject.toml | Added API package to workspace and optional dependencies |
| packages/api/pyproject.toml | New package configuration with proper dependencies |
| packages/api/README.md | Added documentation for the forwarding API usage |
| packages/api/Dockerfile | New optimized Dockerfile with UV and dependency caching |
| docker-compose.yml | Updated build context and removed unnecessary volume mount |
| docker-compose-postgres.yml | Removed entire PostgreSQL configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-on from #43 to:
src/apiauvpackage inpackages/apiDATA_FOLDERfor mounting the forwarding API data volumepyonband send docs to the forwarding API for processingtest_inference_single_file_upload_kreuzbergandtest_inference_on_folder_kreuzbergboth pass (these tests use the forwarding API)