Prefix any unused method arguments with an underscore

withshubh · withshubh · commit 83dad5ba2743 · 2021-02-18T22:36:55.000+05:30
diff --git a/lib/onelogin/ruby-saml/response.rb b/lib/onelogin/ruby-saml/response.rb
@@ -727,7 +727,7 @@ def validate_issuer
       # @return [Boolean] True if the SessionNotOnOrAfter of the AuthnStatement is valid, otherwise (when expired) False if soft=True
       # @raise [ValidationError] if soft == false and validation fails
       #
-      def validate_session_expiration(soft = true)
+      def validate_session_expiration(_soft = true)
         return true if session_expires_at.nil?
 
         now = Time.now.utc

Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,7 @@ def validate_issuer`
`727`	`727`	`# @return [Boolean] True if the SessionNotOnOrAfter of the AuthnStatement is valid, otherwise (when expired) False if soft=True`
`728`	`728`	`# @raise [ValidationError] if soft == false and validation fails`
`729`	`729`	`#`
`730`		`- def validate_session_expiration(soft = true)`
	`730`	`+ def validate_session_expiration(_soft = true)`
`731`	`731`	`return true if session_expires_at.nil?`
`732`	`732`
`733`	`733`	`now = Time.now.utc`