Skip to content

Commit 4a7ba30

Browse files
authored
docs: Language Review
2 parents 97bfe6d + 755c34b commit 4a7ba30

File tree

16 files changed

+132
-119
lines changed

16 files changed

+132
-119
lines changed
Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 🐞 Bug report
2-
description: File a bug/issue to help us improve
2+
description: Report a bug or documentation issue to help us improve
33
title: "[BUG]"
44
labels: [bug, needs-triage]
55
body:
@@ -8,45 +8,45 @@ body:
88
label: Is there an existing issue for this?
99
description: Please search to see if an issue already exists for the bug you encountered.
1010
options:
11-
- label: I have searched the existing issues
11+
- label: I have searched the existing issues.
1212
required: true
1313
- type: dropdown
1414
id: area
1515
attributes:
16-
label: What type of issue are you facing
17-
description: What type of issue are you facing?
16+
label: Issue Type
17+
description: Choose the type of issue you'd like to report.
1818
options:
19-
- bug report
20-
- documentation issue
19+
- Bug Report
20+
- Documentation Issue
2121
validations:
2222
required: true
2323
- type: textarea
2424
attributes:
25-
label: Describe the bug
26-
description: Provide a clear and concise description of what the bug is.
25+
label: Descripton
26+
description: Provide a clear and concise description of the problem. Describe where it appears, when it occurred, and what it affects.
2727
validations:
2828
required: true
2929
- type: textarea
3030
attributes:
3131
label: Expected Behavior
32-
description: A concise description of what you expected to happen.
32+
description: Describe what you expect to happen.
3333
validations:
3434
required: false
3535
- type: textarea
3636
attributes:
37-
label: Add screenshots to help explain your problem
37+
label: Screenshots
3838
description: |
39-
If applicable, add screenshots to help explain your problem.
39+
Optionally, add screenshots to help explain your problem.
4040
41-
Tip: You can attach images or files by clicking this area to highlight it and then dragging files in.
41+
Tip: To attach images or files, click this area to highlight it and then drag files in.
4242
validations:
4343
required: false
4444
- type: textarea
4545
attributes:
46-
label: Additional context
46+
label: Additional Context
4747
description: |
48-
Add any other context like links or references about the problem here. Anything that will give us more context about the issue you are encountering!
48+
Add any other context, like links or references about the problem. Anything that gives us more context about the issue you are encountering.
4949
50-
Tip: You can attach images or files by clicking this area to highlight it and then dragging files in.
50+
Tip: To attach images or files, click this area to highlight it and then drag files in.
5151
validations:
5252
required: false

.github/ISSUE_TEMPLATE/feature_request.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,39 +5,39 @@ labels: [enhancement, pending-decision]
55
body:
66
- type: dropdown
77
attributes:
8-
label: What area do you want to see improved?
9-
description: Specify the main area that you want to see improved.
8+
label: Improvement Area
9+
description: Choose the area that you want to see improved.
1010
options:
11-
- samples
12-
- documentation
13-
- other
11+
- Samples
12+
- Documentation
13+
- Other
1414
validations:
1515
required: true
1616
- type: textarea
1717
id: area
1818
attributes:
19-
label: Is your feature request related to a problem? Please describe.
20-
description: Provide a clear and concise description of what the problem is e.g., I am always frustrated when [...]
19+
label: Is your feature request related to a problem?
20+
description: Provide a clear and concise description of what the problem is. For example, I am always frustrated when ...
2121
validations:
2222
required: true
2323
- type: textarea
2424
attributes:
25-
label: Describe the solution you would like
26-
description: A clear and concise description of what you want to happen.
25+
label: Desired Solution
26+
description: A clear and concise description of the solution you would like to see.
2727
validations:
2828
required: true
2929
- type: textarea
3030
attributes:
31-
label: Describe alternatives you have considered
32-
description: A clear and concise description of any alternative solutions or features you have considered.
31+
label: Alternative Solutions
32+
description: Describe any alternative solutions or features you have considered.
3333
validations:
3434
required: false
3535
- type: textarea
3636
attributes:
37-
label: Additional context
37+
label: Additional Context
3838
description: |
3939
Add any other context like links or references about the problem here. Anything that will give us more context about the issue you are encountering!
4040
41-
Tip: You can attach images or files by clicking this area to highlight it and then dragging files in.
41+
Tip: To attach images or files, click this area to highlight it and then drag files in.
4242
validations:
4343
required: false

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
## Purpose
2-
<!-- Describe the intention of the changes being proposed. What problem does it solve or functionality does it add? -->
2+
<!-- Describe the purpose of the change you are proposing. What problem does it solve or functionality does it add? -->
33
- ...
44

55
## Pull Request Type
66

7-
What kind of change does this Pull Request introduce?
8-
<!-- Please check the one that applies to this PR using "X". -->
7+
What kind of change does this pull request introduce?
8+
<!-- To check the type that applies to this PR, add an "X". -->
99
```
1010
[ ] Bugfix
1111
[ ] Feature
12-
[ ] Refactoring (no functional changes, no api changes)
13-
[ ] Documentation content changes
12+
[ ] Refactoring (no functional changes, no API changes)
13+
[ ] Documentation improvement
1414
[ ] Other... Please describe:
1515
```
1616

.github/workflows/feature-request-response.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
if: ${{ contains(github.event.issue.labels.*.name, 'enhancement') }}
1212
runs-on: ubuntu-latest
1313
steps:
14-
- name: 'Add community note to new Issues'
14+
- name: 'Add community note to new issues'
1515
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
1616
with:
1717
issue-number: ${{ github.event.issue.number }}
@@ -23,7 +23,7 @@ jobs:
2323
### Voting for Prioritization
2424
2525
* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original post to help the community and maintainers prioritize this request.
26-
* Please **do not** leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
26+
* Please **do not** leave "+1" or other comments that do not add relevant new information or questions. They generate extra noise for issue followers and do not help prioritize the request.
2727
2828
### Volunteering to Work on This Issue
2929

.github/workflows/links-watcher-cron.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
if: failure()
3939
with:
4040
title: Link Checker Report
41-
# If issue number is empty a new issue gets created
41+
# If issue number is empty, a new issue is created
4242
issue-number: ${{ steps.find_issue.outputs.issue-number }}
4343
content-filepath: ./lychee/out.md
4444
labels: broken link, automated issue

.github/workflows/stale-handling.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ jobs:
1313
steps:
1414
- uses: actions/stale@v9
1515
with:
16-
stale-issue-message: 'This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.'
17-
stale-pr-message: 'This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.'
16+
stale-issue-message: 'This issue is stale because it has been open 15 days with no activity. Remove stale label or comment, or this will be closed in 5 days.'
17+
stale-pr-message: 'This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment, or this will be closed in 5 days.'
1818
close-issue-message: 'This issue was closed because it has been stalled for 5 days with no activity.'
1919
close-pr-message: 'This PR was closed because it has been stalled for 5 days with no activity.'
2020
days-before-stale: 15

README.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,25 @@
66

77
## Description
88

9-
This repository provides tangible samples based on the good practices and examples given in the [SAP BTP Administrator's Guide](https://help.sap.com/docs/btp/btp-admin-guide/btp-admin-guide) on [help.sap.com](https://help.sap.com/docs/).
9+
This repository provides samples based on the recommendations given in the [SAP BTP Administrator's Guide](https://help.sap.com/docs/btp/btp-admin-guide/btp-admin-guide) on [help.sap.com](https://help.sap.com/docs/).
1010

11-
The provided samples show the implementation of the guidelines using Infrastructure as Code namely [Terraform](https://www.terraform.io/)/[OpenTofu](https://opentofu.org/). This should support in getting started with a sustainable setup of your SAP BTP accounts following our recommendations.
11+
These samples show the implementation of the recommendations using Infrastructure as Code, namely [Terraform](https://www.terraform.io/) or [OpenTofu](https://opentofu.org/). They help you getting started with a sustainable setup of your SAP BTP accounts following our best practices.
1212

1313
## Content Structure
1414

1515
TODO
1616

17-
## How to obtain support
17+
## Getting Support
1818

19-
❓ - If you have a *question* you can ask it here in [GitHub Discussions](https://github.com/SAP-samples/btp-admin-guide-samples/discussions/).
19+
❓ - If you have a *question*, ask it in [GitHub Discussions](https://github.com/SAP-samples/btp-admin-guide-samples/discussions/).
2020

21-
🐞 - If you find a bug, feel free to create a [bug report](https://github.com/SAP-samples/btp-admin-guide-samples/issues/new?assignees=&labels=bug%2Cneeds-triage&projects=&template=bug_report.yml&title=%5BBUG%5D).
22-
23-
💡 - If you have an idea for improvement or a feature request, please open a [feature request](https://github.com/SAP-samples/btp-admin-guide-samples/issues/new?assignees=&labels=enhancement%2Cneeds-triage&projects=&template=feature_request.yml&title=%5BFEATURE%5D).
21+
🐞 - If you find a bug, please create a [bug report](https://github.com/SAP-samples/btp-admin-guide-samples/issues/new?assignees=&labels=bug%2Cneeds-triage&projects=&template=bug_report.yml&title=%5BBUG%5D).
2422

23+
💡 - If you have an idea for improvement or a feature request, feel free to open a [feature request](https://github.com/SAP-samples/btp-admin-guide-samples/issues/new?assignees=&labels=enhancement%2Cneeds-triage&projects=&template=feature_request.yml&title=%5BFEATURE%5D).
2524

2625
## Contributing
2726

28-
If you wish to contribute code, offer fixes or improvements, please send a pull request. Due to legal reasons, contributors will be asked to accept a DCO when they create the first pull request to this project. This happens in an automated fashion during the submission process. SAP uses [the standard DCO text of the Linux Foundation](https://developercertificate.org/).
27+
If you'd like to contribute code, fixes, or improvements, please create a pull request. Due to legal reasons, contributors must accept a DCO. When you create your first pull request to this project, you are automatically asked to accept the DCO. SAP uses [the standard DCO text of the Linux Foundation](https://developercertificate.org/).
2928

3029
## Code of Conduct
3130

sample-setups/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Paradigms
44

5-
We follow the paradigms of a simple and clear Terraform configuration as laid out in the [Simple, Clear, Maintainable](https://rosesecurity.dev/blog/2024/11/24/terraform-proverbs) blog post of the [Development Log](https://rosesecurity.dev/) especially:
5+
We follow the paradigms of a simple and clear Terraform configuration as laid out in [Simple, Clear, Maintainable](https://rosesecurity.dev/blog/2024/11/24/terraform-proverbs); especially:
66

77
- Clear is better than clever.
88
- Modules should be reusable, not rigid.
@@ -13,18 +13,18 @@ We follow the paradigms of a simple and clear Terraform configuration as laid ou
1313
- Name with underscores, not dashes.
1414
- Using locals makes code descriptive and maintainable.
1515

16-
## Naming Conventions and Tagging
16+
## Naming Conventions and Labeling
1717

18-
Ensuring naming conventions is one import aspect when provisioning and managing your SAP BTP account. We will align our samples in accordance to the [Naming Conventions for SAP BTP Accounts](https://help.sap.com/docs/btp/btp-admin-guide/naming-conventions-for-sap-btp-accounts).
18+
Consistent naming conventions are one import aspect when provisioning and managing your SAP BTP account. Our samples follow the [Naming Conventions for SAP BTP Accounts](https://help.sap.com/docs/btp/btp-admin-guide/naming-conventions-for-sap-btp-accounts).
1919

20-
To ensure consistent naming of your resources, we encapsulate the guidelines in dedicated module. Besides the naming we will also include the labels that can be attached to some resources on SAP BTP.
20+
To ensure consistent naming of your resources, we encapsulate the guidelines in a dedicated module. Besides the naming, we also include the labels that can be attached to some resources on SAP BTP.
2121

2222
We have created one module for the level of the [directory](./modules/sap-btp-naming-conventions-directory/README.md) and one for the level of the [subaccount](./modules/sap-btp-naming-conventions-subaccount/README.md).
2323

2424
## Setup of Directories
2525

26-
The setup of directories as a structuring element for the subaccounts is configured in the folder `basic-setup/directory-setup`. The Details about the setup are described in the [README.md](./basic-setup/directory-setup/README.md) file.
26+
The folder `basic-setup/directory-setup` contains the setup of directories as a structuring element for the subaccounts. For details, see [README.md](./basic-setup/directory-setup/README.md).
2727

2828
## Setup of Subaccounts
2929

30-
The setup of subaccounts is configured in the folder `basic-setup/subaccount-setup`. The Details about the setup are described in the [README.md](./basic-setup/subaccount-setup/README.md) file.
30+
The folder `basic-setup/subaccount-setup` contains the setup of subaccounts. For details, see the [README.md](./basic-setup/subaccount-setup/README.md) file.

sample-setups/basic-setup/directory-setup/README.md

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,43 @@
22

33
## Assumptions
44

5-
- We assume that we use the directories as structuring element for the subaccounts i.e., in an unmanaged fashion.
5+
- We assume that we use the directories as structuring element for the subaccounts; that is, in an unmanaged fashion.
66
- We assume that we do the directory setup in one run for all involved departments.
77

88
## Design Decisions
99

10-
We decouple the directory creation i.e., the setup of the basic structure from the creation of the operational units namely the subaccounts inside of the directories. The changes on directory level are probably a rare scenario compared to changes in the subaccounts additionally depending on their stage. We want to avoid side effects as well as lengthy state refreshes and keep the state of the directories separate.
10+
We decouple the directory creation (the setup of the basic structure) from the creation of the operational units (the subaccounts within the directories). Typically, changes on directory level happen less frequently than changes in the subaccounts additionally depending on their stage. We want to avoid side effects as well as lengthy state refreshes and keep the state of the directories separate.
1111

1212
## Directory Setup
1313

14-
The creation of the directories is steered by a map of objects that define the business data relevant for a directory namely:
14+
To create the directories, we use a map of objects that define the business data relevant for a directory, such as the following:
1515

16-
- business_unit (`string`): The business unit that owns the directory e.g., HR, IT, Finance
17-
- costcenter (`string`): Cost center of the business unit
18-
- directory_contacts (`list(string)`): List of email addresses representing the directory contacts
19-
- region (`string`): The geographical region of the directory e.g., EMEA
16+
- business_unit (`string`): The business unit that owns the directory, such as HR, IT, or Sales
17+
- costcenter (`string`): The cost center of the business unit
18+
- directory_contacts (`list(string)`): The list of email addresses representing the directory contacts
19+
- region (`string`): The geographical region of the directory, for example, EMEA
2020

21-
This is input data is reflected by the variables defined in the [variables.tf](./variables.tf) file
21+
This is input data is reflected by the variables defined in the [variables.tf](./variables.tf) file.
2222

23-
The directories are provisioned via the [main.tf](./main.tf) file which delegates to the module [base-directory-setup](../../modules/base-directory-setup/README.md). This module combines the corresponding module containing the naming and labeling conventions for a directory and calls the Terraform resource [btp_directory](https://registry.terraform.io/providers/SAP/btp/latest/docs/resources/directory).
23+
The directories are provisioned with the [main.tf](./main.tf) file, which delegates to the module [base-directory-setup](../../modules/base-directory-setup/README.md). This module combines the corresponding module containing the naming and labeling conventions for a directory, and calls the Terraform resource [btp_directory](https://registry.terraform.io/providers/SAP/btp/latest/docs/resources/directory).
2424

25-
After provisioning the output summarizes the executed setup as given by the [outputs.tf](./outputs.tf) file. Here is an example how the output could look like:
25+
After provisioning the output, it summarizes the executed setup as given by the [outputs.tf](./outputs.tf) file. See the following example how the output could look like:
2626

27-
![Sample Output for a directory](../../../assets/base-directory-output.png)
27+
<!-- screenshots are disencouraged because they're harder to keep up to date ![Sample Output for a directory](../../../assets/base-directory-output.png) -->
28+
29+
```json
30+
Outputs:
31+
32+
directories = {
33+
"directory1" = {
34+
"business_unit" = "HR"
35+
"costcenter" = "123456"
36+
"id" = "cf12345f-1234567890"
37+
"name" = "Sales-EMEA"
38+
"region" = "EMEA"
39+
}
40+
}
41+
```
2842

2943
## SAP BTP Administrator's Guide - References
3044

0 commit comments

Comments
 (0)