Skip to content

DC Mission 3501 - Polished for QAS #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2024
Merged

DC Mission 3501 - Polished for QAS #319

merged 4 commits into from
Sep 20, 2024

Conversation

mahesh0431
Copy link
Contributor

Purpose

  • DC Mission 3501 - Polished for QAS

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Documentation content changes
[X] Other... Please describe: Code clean up for QAS

Other Information

rui1610
rui1610 reviewed Sep 19, 2024
View reviewed changes
rui1610
rui1610 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please address the comment I've added? Thanks a lot!

jglander
jglander suggested changes Sep 20, 2024
View reviewed changes
jglander
jglander suggested changes Sep 20, 2024
View reviewed changes
jglander
jglander approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jglander jglander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good, thank you Mahesh.

With this I approved the pr-319.

rui1610
rui1610 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rui1610 rui1610 merged commit 493054a into SAP-samples:main Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@jglander jglander jglander approved these changes

@rui1610 rui1610 rui1610 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahesh0431 @jglander @rui1610 @lechnerc77