Skip to content

DC Mission 3945 - Polished for QAS #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 24, 2024
Merged

DC Mission 3945 - Polished for QAS #321

merged 11 commits into from
Sep 24, 2024

Conversation

mahesh0431
Copy link
Contributor

Purpose

  • DC Mission 3945 - Polished for QAS

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Documentation content changes
[X] Other... Please describe: Code clean up for QAS

Other Information

jglander
jglander suggested changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@jglander jglander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add service instance dashboard url.

Same as in #320

@mahesh0431
Copy link
Contributor Author

@jglander , this is added now. Thanks!!

jglander
jglander approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@jglander jglander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qas enabled version looks good to me, sapids and custom idp both work for me.

@lechnerc77 lechnerc77 enabled auto-merge (squash) September 24, 2024 06:53
@lechnerc77 lechnerc77 merged commit ee32aad into SAP-samples:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

+1 more reviewer

@jglander jglander jglander approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahesh0431 @jglander @lechnerc77