-
Notifications
You must be signed in to change notification settings - Fork 186
Typescript configuration for Fiori elements apps #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
devinea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c-kobo A few small comments to align with fiori tools generation of new projects.
I noticed a test failing here.
http://localhost:4004/sap.fe.cap.travel/test/integration/Opa.qunit.html
Co-authored-by: Austin Devine <[email protected]>
Co-authored-by: Austin Devine <[email protected]>
- Avoid log pollution from `cds-ui5-plugin` by using `deploy --out` param instead of capturing all stdout - Update Java pom: parent-less pom, cds-service 3.5.0
|
Look Ma, it's green 🥳 |
chgeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as this is to be shown tomorrow in CAP product day.
Aligned with @Akatuoro that he rebases his TS simplificiations on top of this one.
Disables the cds ui5 plugin for mocha tests, removing the need for the forceful mocha exit introduced with #1286 . --------- Co-authored-by: Christian Georgi <[email protected]>
|
@chgeo Is there any reason, why this PR removed the Spring Boot parent POM from the Java build? This actually broke one of our scenarios which requires Maven profiles that come with the Spring Boot parent POM. Sadly this went undetected until now (thanks to #1454), even though we thought we tested this scenario nightly, but the Maven build just did less than expected, because the said Maven profiles were removed, and still was successful. |
|
@beckermarc sorry, I have no idea other than the commit message which indicates there was a build issue. |
Yep, because we use the GraalVM Native Image feature in this project, which requires the Spring Boot parent pom. We don't enable projects for that feature by default with I will look into a PR to restore the previous behaviour next week. No worries :) |
Thanks! |
This PR enables typescript for both apps Travel Processor and Travel Analytics.
Additionally, for the Travel Processor App, the following flexible programming model based extensions are added:
Other changes
karma-ui5-transpileto get TS working in Karma testsapp/*/package=lock.jsonfileskarma.conffilesodata.test.jswhich also caused problems withts-jestnpm cicalls in pipelinedeploy -outparam in Maven build to not be disturbed by extra stdout ouput fromcds-ui5-plugin