Skip to content

Conversation

@c-kobo
Copy link
Member

@c-kobo c-kobo commented Nov 20, 2024

This PR enables typescript for both apps Travel Processor and Travel Analytics.
Additionally, for the Travel Processor App, the following flexible programming model based extensions are added:

  • a custom section combining a message strip and a table building block. This replaces the standard booking table section
  • a controller extension: when saving, it is checked whether trees-4-tickets checkbox has been selected, a dialog is shown giving the user the option to do so before save continues.

Other changes

  • Fix bad extraneous field in Travels.csv file
  • Show server stdout in Karma runs
  • Use karma-ui5-transpile to get TS working in Karma tests
  • Delete obsolete app/*/package=lock.json files
  • Unified double karma.conf files
  • Java 21 in pipeline
  • Drop Node 18 in pipeline
  • Remove obsolete odata.test.js which also caused problems with ts-jest
  • Remove obsolete npm ci calls in pipeline
  • Use deploy -out param in Maven build to not be disturbed by extra stdout ouput from cds-ui5-plugin
  • Replace parent pom by SpringBoot bom
  • Use latest SpringBoot 3.41
  • Use latest CAP Java 3.5.0

@c-kobo c-kobo changed the title Typescript configuration and for Fiori elements apps Typescript configuration for Fiori elements apps Nov 20, 2024
Copy link
Contributor

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-kobo A few small comments to align with fiori tools generation of new projects.
I noticed a test failing here.
http://localhost:4004/sap.fe.cap.travel/test/integration/Opa.qunit.html

@chgeo
Copy link
Member

chgeo commented Nov 29, 2024

Look Ma, it's green 🥳

Copy link
Member

@chgeo chgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as this is to be shown tomorrow in CAP product day.

Aligned with @Akatuoro that he rebases his TS simplificiations on top of this one.

@chgeo chgeo merged commit 2b0ac22 into main Dec 2, 2024
3 checks passed
@chgeo chgeo deleted the typescript branch December 2, 2024 09:39
Akatuoro added a commit that referenced this pull request Dec 3, 2024
Disables the cds ui5 plugin for mocha tests, removing the need for the
forceful mocha exit introduced with #1286 .

---------

Co-authored-by: Christian Georgi <[email protected]>
@beckermarc
Copy link
Contributor

beckermarc commented May 16, 2025

@chgeo Is there any reason, why this PR removed the Spring Boot parent POM from the Java build? This actually broke one of our scenarios which requires Maven profiles that come with the Spring Boot parent POM.

Sadly this went undetected until now (thanks to #1454), even though we thought we tested this scenario nightly, but the Maven build just did less than expected, because the said Maven profiles were removed, and still was successful.

@chgeo
Copy link
Member

chgeo commented May 16, 2025

@beckermarc sorry, I have no idea other than the commit message which indicates there was a build issue.
Maybe I was misled there, but certainly followed the parent-less structure that the current archetype generates. This means we want to deviate here?

@beckermarc
Copy link
Contributor

This means we want to deviate here?

Yep, because we use the GraalVM Native Image feature in this project, which requires the Spring Boot parent pom. We don't enable projects for that feature by default with cds init.

I will look into a PR to restore the previous behaviour next week. No worries :)

@chgeo
Copy link
Member

chgeo commented May 16, 2025

I will look into a PR to restore the previous behaviour next week. No worries :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants