Fix incorrectly placed @Order annotations #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjayasinghe
approved these changes
Sep 22, 2025
Member
rjayasinghe
left a comment
rjayasinghe
left a comment
There was a problem hiding this comment.
I assume actuators were not accessible before this change and work after this change, right? If that's the case this is approved. :)
Member
|
I think we can ignore the failing node.js CI because this changes don't have any influence on the node.js runtime. |
Contributor
Author
|
No, it already worked before, however only due to coincidence. The @order is correctly placed on the bean method, although not strictly necessary at the moment, as application beans have priority over beans configured through auto configuration anyway. However it might become necessary in the future, if we would fix the same bug (fully) in cds-services as well. See also the PR I'm opening there if you are interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.