Skip to content

Commit 42c171b

Browse files
authored
Merge pull request #13 from SAP-samples/refactor/exercises-remove-todos
refactor(exercises): remove TS based todo comments
2 parents f1181a4 + c8adf70 commit 42c171b

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

exercises/ex04/sample.p13n/webapp/control/P13nTable.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import Table, { $TableSettings } from "sap/m/Table"
22
import Engine, { State } from "sap/m/p13n/Engine"
33
import SelectionController from "sap/m/p13n/SelectionController"
4-
// @ts-ignore TODO: FIX export of MetadataObject type
54
import MetadataHelper, { MetadataObject } from "sap/m/p13n/MetadataHelper"
65
import Column from "sap/m/Column"
76
import Text from "sap/m/Text"
@@ -24,7 +23,6 @@ export default class P13nTable extends Table {
2423

2524
constructor(id?: string, settings?: $TableSettings) {
2625
super(id, settings)
27-
// @ts-ignore TODO: FIX static method declaration
2826
this.engine = Engine.getInstance()
2927
this.initialized = new Promise((resolve: () => void): void => {
3028
this.attachEventOnce("updateFinished", (): void => {
@@ -47,13 +45,11 @@ export default class P13nTable extends Table {
4745
}
4846
})
4947

50-
// @ts-ignore TODO: FIX constructor
5148
this.helper = new MetadataHelper(columnsMetadata)
5249

5350
this.engine.register(this, {
5451
helper: this.helper,
5552
controller: {
56-
// @ts-ignore TODO: FIX constructor
5753
Columns: new SelectionController({
5854
control: this,
5955
targetAggregation: "columns"

exercises/ex06/sample.p13n/webapp/control/P13nTable.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ export default class P13nTable extends Table {
3333

3434
constructor(id?: string, settings?: $TableSettings) {
3535
super(id, settings)
36-
// @ts-ignore TODO: FIX static method declaration
3736
this.engine = Engine.getInstance()
3837
this.initialized = new Promise((resolve: () => void): void => {
3938
this.attachEventOnce("updateFinished", (): void => {

exercises/ex09/sample.p13n/webapp/control/P13nTable.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ export default class P13nTable extends Table {
3333

3434
constructor(id?: string, settings?: $TableSettings) {
3535
super(id, settings)
36-
// @ts-ignore TODO: FIX static method declaration
3736
this.engine = Engine.getInstance()
3837
this.initialized = new Promise((resolve: () => void): void => {
3938
this.attachEventOnce("updateFinished", (): void => {

0 commit comments

Comments
 (0)