Skip to content

SapMachine (26) #2137: Linux: We should use transparent huge pages in some configurations #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheRealMDoerr merged 1 commit into from
Dec 18, 2025
Merged

SapMachine (26) #2137: Linux: We should use transparent huge pages in some configurations #2142

TheRealMDoerr merged 1 commit into from
Dec 18, 2025
+31 −10

Conversation

@TheRealMDoerr
Copy link
Member

@TheRealMDoerr TheRealMDoerr commented Dec 12, 2025 •
edited
Loading

Cherry-picked #2138.

fixes #2137

@SapMachine
Copy link
Member

SapMachine commented Dec 12, 2025

Hello @TheRealMDoerr, this pull request fulfills all formal requirements.

@TheRealMDoerr TheRealMDoerr force-pushed the 26_2137_TransparentHugePages branch from 57af063 to cca2fc3 Compare December 17, 2025 10:19
@SapMachine
Copy link
Member

SapMachine commented Dec 17, 2025

Hello @TheRealMDoerr, this pull request fulfills all formal requirements.

@RealCLanger
Copy link
Member

RealCLanger commented Dec 17, 2025

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you thing this is wrong or need any assistance, please contact [email protected].

@TheRealMDoerr, you commit is done as "Author: Martin [email protected]". I guess you should really check this and change it to your SAP mail address.

@TheRealMDoerr
SapMachine #2137: Linux: We should use transparent huge pages in some…
06b48eb 
… configurations (#2138)

Linux: Enable UseTransparentHugePages if
- UseLargePages and UseTransparentHugePages are not set explicitly
- transparent huge pages are supported by the system configuration and the huge pages size is not above 2MB
- UseZGC or UseShenandoahGC are not selected
- the Java Heap is not set to 128MB or lower
@TheRealMDoerr TheRealMDoerr force-pushed the 26_2137_TransparentHugePages branch from cca2fc3 to 06b48eb Compare December 17, 2025 13:22
@TheRealMDoerr
Copy link
Member Author

TheRealMDoerr commented Dec 17, 2025

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.
If you thing this is wrong or need any assistance, please contact [email protected].

@TheRealMDoerr, you commit is done as "Author: Martin [email protected]". I guess you should really check this and change it to your SAP mail address.

Seems like that got broken by "Sqash and merge" in the original Commit. Fixed manually (and force-pushed).

@SapMachine
Copy link
Member

SapMachine commented Dec 17, 2025

Hello @TheRealMDoerr, this pull request fulfills all formal requirements.

RealCLanger
RealCLanger approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The AIX and ppc64 builds did not report back to GitHub due to an issue with Github rate limit exceeded. However, builds were successful.

parttimenerd
parttimenerd approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@parttimenerd parttimenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make this clear in our "Changes to OpenJDK page"

@TheRealMDoerr TheRealMDoerr merged commit f0a13ea into sapmachine26 Dec 18, 2025
192 of 194 checks passed
@TheRealMDoerr TheRealMDoerr deleted the 26_2137_TransparentHugePages branch December 18, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parttimenerd parttimenerd parttimenerd approved these changes

@RealCLanger RealCLanger RealCLanger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TheRealMDoerr @SapMachine @RealCLanger @parttimenerd