[SKTD] New object type: Knowledge transfer documents#270
[SKTD] New object type: Knowledge transfer documents#270uenal-akkaya wants to merge 16 commits intoSAP:mainfrom
Conversation
|
|
|
Thanks @uenal-akkaya. I suggest to convert this PR to a draft. Is this fine for you? |
|
@schneidermic0 You can convert this to a draft. Thanks. |
Fix abaplint issue Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
schneidermic0
left a comment
schneidermic0
left a comment
There was a problem hiding this comment.
Thanks @uenal-akkaya. I would like to request some changes. See my comments/suggestions.
schneidermic0
changed the title
|
@uenal-akkaya Thanks for the update. The editor configuration shows that there are some whitespaces in empty lines. Are they really necessary. If not, can we remove them? |
Not sure which the editor configuration is. Can you name them? |
|
The repository is checked by an editorconfig file. See https://github.com/SAP/abap-file-formats/blob/34ad66189f7e39bb5aa10cb125f8dd90233b4e43/.editorconfig. The config checks whether there are any unnecessary whitespace in the code, because this might lead to unnecessary diffs if you compare it to new changes. |
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.sktd.json` | 1 | [`zif_aff_sktd_v1.intf.abap`](./type/zif_aff_sktd_v1.intf.abap) | [`sktd-v1.json`](./sktd-v1.json) | [`z_aff_example_sktd.sktd.json`](./examples/z_aff_example_sktd.sktd.en.json) |
There was a problem hiding this comment.
Wrong link to the JSON example file.
| `<name>.sktd.json` | 1 | [`zif_aff_sktd_v1.intf.abap`](./type/zif_aff_sktd_v1.intf.abap) | [`sktd-v1.json`](./sktd-v1.json) | [`z_aff_example_sktd.sktd.json`](./examples/z_aff_example_sktd.sktd.en.json) | |
| `<name>.sktd.json` | 1 | [`zif_aff_sktd_v1.intf.abap`](./type/zif_aff_sktd_v1.intf.abap) | [`sktd-v1.json`](./sktd-v1.json) | [`z_aff_example_sktd.sktd.json`](./examples/z_aff_example_sktd.sktd.en.json) |
Please also add the link to the markdown file.
| # ensure the LF line endings for SKTD markdowns | ||
| [*.md] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| insert_final_newline = true |
There was a problem hiding this comment.
This configuration must not run for all *.md files. For other *.md files trailing whitespaces shall still be checked
There was a problem hiding this comment.
You mean, the .md file in the AFF for SKTD is allowed to have trailing whitespaces?
There was a problem hiding this comment.
Try adding to the original '.editorconfig'
[/file-formats/sktd/**/*.md]
trim_trailing_whitespace = unset
However, having trailing whitespaces might lead to undesired diffs.
There was a problem hiding this comment.
Thanks!
Yes, you are right. This is also what I mentioned earlier. See #270 (comment)
Currently, @uenal-akkaya tends to keep them anyway. But this is still in discussion ;) If we can avoid this exemption, it would be great. :)
4 participants
No description provided.