Update non-major dependencies #11
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ jobs: | |
| if: github.actor != 'ospo-renovate[bot]' | ||
| runs-on: [ubuntu-latest] | ||
| steps: | ||
| - uses: SAP/ai-assisted-github-actions/pr-summary@e30d0a9b55431531b1c92a58dc96b6ab21791fed # v3.0.1 | ||
|
There was a problem hiding this comment. Consider using a version tag instead of a SHA hash to make it clear which version is intended and easier maintainability. You can use: \n\n There was a problem hiding this comment. Consider revising the version references in the action usage comments for clarity and maintainability. Instead of '# v3.0.1', which might incorrectly suggest that it refers to a version tag in the repository, you could use a clearer format without the prefix or ensure it directly maps to a real version for your workflow documentation. |
||
| with: | ||
| aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }} | ||
| model: gpt-4o | ||
|
|
@@ -22,7 +22,7 @@ jobs: | |
| if: github.actor != 'ospo-renovate[bot]' | ||
| runs-on: [ubuntu-latest] | ||
|
There was a problem hiding this comment. In the second part of your code under 'if: github.actor != 'ospo-renovate[bot]'', apply similar improvements by either explicitly defining multiple runners or simplifying the format when using only a single runner. Replace it with: runs-on: ubuntu-latestThis enhances clarity and prevents errors when additional runners are needed. |
||
| steps: | ||
| - uses: SAP/ai-assisted-github-actions/pr-review@e30d0a9b55431531b1c92a58dc96b6ab21791fed # v3.0.1 | ||
|
There was a problem hiding this comment. Similarly, use version tags for consistency and easier updates when newer versions are released. Use: \n\n There was a problem hiding this comment. Similarly, in the PR review section, ensure that the comment referencing '# v3.0.1' accurately reflects the action version tag or purpose to avoid confusion. If the tag does not exist in the repository, consider using a note or comment that provides information about the action without implying a version tag in '# v3.0.1'. |
||
| with: | ||
| aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }} | ||
| model: gpt-4o | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When specifying 'runs-on', it's preferable to be explicit in using the array syntax if there's only one runner specified, to adhere to YAML best practices or switch to single value format for simplicity. Replace it with:
This ensures readability and consistency, especially if the number of runners increases in the future.