Skip to content

Refactor build workflows #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-richter merged 8 commits into from
Jul 21, 2025
Merged

Refactor build workflows #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c03918a
Refactor AI-assisted action execution to use matrix strategy
daniel-richter Jul 21, 2025
2a12c4a
Refactor testing jobs to separate PR Summary and PR Review actions
daniel-richter Jul 21, 2025
458520c
Update AI model from gpt-4o to o3 in PR Summary and PR Review actions
daniel-richter Jul 21, 2025
7187aca
Add permissions to jobs in workflow files for proper access control
daniel-richter Jul 21, 2025
6cdd925
Disable major updates for SAP/ai-assisted-github-actions in Renovate …
daniel-richter Jul 21, 2025
71a8c05
Update AI model to anthropic--claude-4-opus in PR Summary and PR Revi…
daniel-richter Jul 21, 2025
67367a4
Update action versions for PR Summary and PR Review steps to v3
daniel-richter Jul 21, 2025
bd13dfb
Update AI model in PR Summary and PR Review actions to anthropic--cla…
daniel-richter Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/ai-assistance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ jobs:
name: PR Summary
if: github.actor != 'ospo-renovate[bot]'
runs-on: [ubuntu-latest]
permissions:
contents: read
pull-requests: write
steps:
- uses: SAP/ai-assisted-github-actions/pr-summary@93162bffd6b396623ffa5b20e4666e427db88414 # v3.0.2
- uses: SAP/ai-assisted-github-actions/pr-summary@v3
Copy link

@github-actions github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a floating tag (v3) can introduce unexpected changes when the action is updated. For reproducible runs, pin the action to a specific minor version or commit SHA. For example:

- uses: SAP/ai-assisted-github-actions/[email protected]

with:
aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }}
model: gpt-4o
model: anthropic--claude-4-sonnet
Copy link

@github-actions github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo in the model name. 'Claude 4 Sonnet' should likely be 'claude-3-sonnet' based on Anthropic's naming convention:

model: claude-3-sonnet
# or
model: claude-3-5-sonnet

Copy link
Contributor Author

@daniel-richter daniel-richter Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://me.sap.com/notes/3437766/E

exclude-files: package-lock.json
display-mode: append
header-text: "---"
Expand All @@ -21,9 +24,12 @@ jobs:
name: PR Review
if: github.actor != 'ospo-renovate[bot]'
runs-on: [ubuntu-latest]
permissions:
contents: read
pull-requests: write
steps:
- uses: SAP/ai-assisted-github-actions/pr-review@93162bffd6b396623ffa5b20e4666e427db88414 # v3.0.2
- uses: SAP/ai-assisted-github-actions/pr-review@v3
Copy link

@github-actions github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, pin the pr-review action to a specific version to ensure stability and prevent breaking changes. For example:

- uses: SAP/ai-assisted-github-actions/[email protected]

with:
aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }}
model: gpt-4o
model: anthropic--claude-4-sonnet
exclude-files: package-lock.json
2 changes: 2 additions & 0 deletions .github/workflows/build-cleanup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
clean-up:
name: Clean up
runs-on: [ubuntu-latest]
permissions:
contents: write
steps:
- uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
Expand Down
31 changes: 26 additions & 5 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
name: Build and push artifacts to release branch
runs-on: [ubuntu-latest]
if: ${{ !startsWith(github.head_ref || github.ref_name, 'release/') }}
permissions:
contents: write
steps:
- name: Checkout source branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -90,11 +92,14 @@ jobs:
git commit -m "${{ github.event.number && format('PR-{0}', github.event.number) || join(github.event.commits.*.message, ', ') }}" || true
git push

testing:
name: Execute the AI-assisted action defined in this PR
testing-summary:
name: Execute the action (PR Summary) defined in this PR
runs-on: [ubuntu-latest]
needs: create-release
if: ${{ github.ref_name != 'main' }}
permissions:
contents: read
pull-requests: write
steps:
- name: Checkout release branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -104,14 +109,28 @@ jobs:
uses: ./pr-summary # action.yml is in the pr-summary folder of the release branch
with:
aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }}
model: gpt-4o
model: o4-mini
exclude-files: package-lock.json
display-mode: comment-delta
- name: Run the AI-assisted action (PR Summary)

testing-review:
name: Execute the action (PR Review) defined in this PR
runs-on: [ubuntu-latest]
needs: create-release
if: ${{ github.ref_name != 'main' }}
permissions:
contents: read
pull-requests: write
steps:
- name: Checkout release branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ env.RELEASE_BRANCH }}
- name: Run the AI-assisted action (PR Review)
uses: ./pr-review # action.yml is in the pr-review folder of the release branch
with:
aicore-service-key: ${{ secrets.AICORE_SERVICE_KEY }}
model: gpt-4o
model: o4-mini
exclude-files: package-lock.json
display-mode: review-comment-delta

Expand All @@ -120,6 +139,8 @@ jobs:
runs-on: [ubuntu-latest]
needs: create-release
if: ${{ github.ref_name == 'main' }}
permissions:
contents: write
steps:
- name: Checkout release branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/code-quality.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
lintCheck:
runs-on: [ubuntu-latest]
name: Linter (${{ matrix.path }})
permissions:
contents: read
strategy:
fail-fast: false
matrix:
Expand All @@ -35,6 +37,8 @@ jobs:
formatCheck:
runs-on: [ubuntu-latest]
name: Formatter (${{ matrix.path }})
permissions:
contents: read
strategy:
fail-fast: false
matrix:
Expand Down
9 changes: 9 additions & 0 deletions .renovaterc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@
"/^@?octokit//",
"/^eslint$/"
]
},
{
"matchDepTypes": [
"action"
],
"matchPackageNames": [
"SAP/ai-assisted-github-actions"
],
"enabled": false
}
],
"schedule": [
Expand Down