Skip to content

Conversation

@daniel-richter
Copy link
Contributor

@daniel-richter daniel-richter commented Jul 21, 2025

If set, then patterns without slashes will be matched
against the basename of the path if it contains slashes. For example,
a?b would match the path /xyz/123/acb, but not /xyz/acb/123.
https://github.com/isaacs/minimatch?tab=readme-ov-file#matchbase

  • Before:
    • package-lock.json pattern would match package-lock.json but not subfolder/package-lock.json
  • After:
    • package-lock.json pattern would match package-lock.json as well as subfolder/package-lock.json

This change enhances file matching capabilities in both PR review and PR summary modules by enabling basename matching in addition to the existing dot file and case-insensitive matching options.

Walkthrough

  • Refactor: Enhanced file matching configuration by adding matchBase: true option to MinimatchOptions in both PR review and summary modules, allowing pattern matching against file basenames rather than full paths for more flexible file filtering.

Model: anthropic--claude-4-sonnet | Prompt Tokens: 617 | Completion Tokens: 93

@github-actions
Copy link

The patch refactors file matching behavior in both the PR review and summary modules by adding the matchBase option to the minimatch configuration. This update enhances pattern matching, allowing wildcard patterns to apply to filenames regardless of directory structure, resulting in more reliable file selection. Users will notice more robust filtering when specifying file globs.

Walkthrough

  • Refactor: Both the PR review and PR summary actions now include matchBase: true in minimatch options to match file globs against base filenames.

Model: o4-mini | Prompt Tokens: 518 | Completion Tokens: 1083

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed your code with AI support to offer friendly suggestions. Some ideas are predictions, not absolute rules—pick what fits your style and goals. You’re in charge of the final decisions; AI is here to help.
Model: o4-mini | Prompt Tokens: 960 | Completion Tokens: 2546

@daniel-richter daniel-richter marked this pull request as ready for review July 21, 2025 14:41
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a collaborative code review powered by AI assistance. These suggestions offer potential improvements and insights to consider, though they're recommendations rather than requirements. You bring the expertise and judgment to decide what fits your project best. Think of this as a helpful second pair of eyes to support your development process.
Model: anthropic--claude-4-sonnet | Prompt Tokens: 1108 | Completion Tokens: 570

@daniel-richter daniel-richter merged commit ca31112 into main Jul 21, 2025
15 checks passed
@daniel-richter daniel-richter deleted the match-base branch July 21, 2025 14:51
github-actions bot pushed a commit that referenced this pull request Jul 21, 2025
Fix matchOptions initialization to include matchBase for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants