Skip to content

Tool versions for asdf version manager #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-richter merged 4 commits into from
Jul 21, 2025
Merged

Tool versions for asdf version manager #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae639c7
Add .tool-versions file for Node.js version management
daniel-richter Jul 21, 2025
516d4e0
Disable major updates for asdf manager in Renovate configuration
daniel-richter Jul 21, 2025
3ca9db9
Update Node.js version management to use .tool-versions file
daniel-richter Jul 21, 2025
6f7326a
Update Node.js version to 20.19.4 in .tool-versions
daniel-richter Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Node (PR Summary)
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version-file: source-folder/pr-summary/.node-version
node-version-file: source-folder/.tool-versions
cache: npm
cache-dependency-path: source-folder/pr-summary/package-lock.json
- name: Build (PR Summary)
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Setup Node (PR Review)
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version-file: source-folder/pr-review/.node-version
node-version-file: source-folder/.tool-versions
cache: npm
cache-dependency-path: source-folder/pr-review/package-lock.json
- name: Build (PR Summary)
Copy link

@github-actions github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in the step names. The first setup is for "PR Summary" but the second build step is also labeled "PR Summary" instead of "PR Review". This creates confusion and makes debugging harder.

- name: Build (PR Review)

This should match the context of the PR Review setup step above it.

Expand Down
9 changes: 9 additions & 0 deletions .renovaterc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,15 @@
"/^eslint$/"
]
},
{
"matchManagers": [
"asdf"
],
"matchUpdateTypes": [
"major"
],
"enabled": false
},
{
"matchDepTypes": [
"action"
Expand Down
1 change: 1 addition & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodejs 20.19.4
Copy link

@github-actions github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment to explain the purpose of this file and the Node.js version choice. This improves maintainability and helps other developers understand the tooling decisions.

# asdf tool versions file
# Node.js version used across the project
nodejs 20.19.4

Also, ensure this Node.js version (20.19.4) is the intended version, as it appears you're downgrading from 22.17.1 based on the deleted files.

1 change: 0 additions & 1 deletion pr-review/.node-version
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pr-summary/.node-version
View file
Open in desktop

This file was deleted.