-
Notifications
You must be signed in to change notification settings - Fork 3
Update script commands in package.json for consistency #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a thoughtful code review enhanced with AI assistance. These observations offer suggestions and insights that may help improve your work, though they're recommendations rather than requirements. You remain the expert on your project's needs and goals. Please take what's useful and leave what isn't—this feedback is simply here to support your development process and decision-making.
Model: anthropic--claude-4-sonnet | Prompt Tokens: 1551 | Completion Tokens: 929
pr-review/package.json
Outdated
| "eslint-plugin-import": "2.32.0", | ||
| "eslint-plugin-sonarjs": "3.0.4", | ||
| "eslint-plugin-unicorn": "60.0.0", | ||
| "npx": "10.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding npx as a dependency is unnecessary and incorrect. The npx command is part of npm and doesn't need to be installed as a separate package. This dependency should be removed as it adds unnecessary bloat to your project.
{
"dependencies": {
"@actions/core": "1.11.1",
"eslint-plugin-import": "2.32.0",
"eslint-plugin-sonarjs": "3.0.4",
"eslint-plugin-unicorn": "60.0.0",
"prettier": "3.6.2",
"tsx": "4.20.3",
"typescript": "5.8.3"
}
}|
Updated development scripts across both packages for consistency and reliability. Build commands now invoke tools directly, start scripts leverage tsx’s Walkthrough
Model: o4-mini | Prompt Tokens: 834 | Completion Tokens: 754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing your code. I’ve provided some AI-powered suggestions to support you. Keep in mind these are possibilities, not certainties, so choose what fits your needs. You’re in charge—AI is here to help.
Model: o4-mini | Prompt Tokens: 1400 | Completion Tokens: 3425
|
The explicit Walkthrough
Model: o4-mini | Prompt Tokens: 402 | Completion Tokens: 368 | Diff Range: e3015d0...704ba45 |
Remove unnecessary
tsxcall.Fix
.envfile loading.This change streamlines the build and development workflow by removing redundant
npxprefixes from npm scripts and modernizing environment variable loading. The modifications affect both pr-review and pr-summary packages, standardizing their configurations and adding npx as an explicit dependency.Walkthrough
npxprefixes from build, lint, and prettier scripts since these tools are already available as project dependencies--env-fileflag for better cross-platform compatibilityModel: anthropic--claude-4-sonnet | Prompt Tokens: 936 | Completion Tokens: 154