Skip to content

Conversation

@daniel-richter
Copy link
Contributor

@daniel-richter daniel-richter commented Jul 25, 2025

Remove unnecessary tsx call.
Fix .env file loading.


This change streamlines the build and development workflow by removing redundant npx prefixes from npm scripts and modernizing environment variable loading. The modifications affect both pr-review and pr-summary packages, standardizing their configurations and adding npx as an explicit dependency.

Walkthrough

  • Chore: Removed unnecessary npx prefixes from build, lint, and prettier scripts since these tools are already available as project dependencies
  • Chore: Updated environment variable loading in the start script from shell sourcing to tsx's native --env-file flag for better cross-platform compatibility
  • Chore: Added npx as an explicit dependency to ensure consistent package execution across environments

Model: anthropic--claude-4-sonnet | Prompt Tokens: 936 | Completion Tokens: 154

@daniel-richter daniel-richter marked this pull request as ready for review July 25, 2025 15:12
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a thoughtful code review enhanced with AI assistance. These observations offer suggestions and insights that may help improve your work, though they're recommendations rather than requirements. You remain the expert on your project's needs and goals. Please take what's useful and leave what isn't—this feedback is simply here to support your development process and decision-making.
Model: anthropic--claude-4-sonnet | Prompt Tokens: 1551 | Completion Tokens: 929

"eslint-plugin-import": "2.32.0",
"eslint-plugin-sonarjs": "3.0.4",
"eslint-plugin-unicorn": "60.0.0",
"npx": "10.2.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding npx as a dependency is unnecessary and incorrect. The npx command is part of npm and doesn't need to be installed as a separate package. This dependency should be removed as it adds unnecessary bloat to your project.

{
  "dependencies": {
    "@actions/core": "1.11.1",
    "eslint-plugin-import": "2.32.0",
    "eslint-plugin-sonarjs": "3.0.4",
    "eslint-plugin-unicorn": "60.0.0",
    "prettier": "3.6.2",
    "tsx": "4.20.3",
    "typescript": "5.8.3"
  }
}

@github-actions
Copy link

Updated development scripts across both packages for consistency and reliability. Build commands now invoke tools directly, start scripts leverage tsx’s --env-file option for streamlined environment loading, and redundant npx prefixes in lint and prettier commands have been removed. The npx package is now listed as a dependency to lock its version.

Walkthrough

  • Refactor: Simplified build commands by removing unnecessary npx prefix for faster invocation.
  • Refactor: Standardized lint and prettier scripts by dropping redundant npx calls.
  • Chore: Introduced npx as a direct dependency to ensure consistent CLI versioning.
  • Refactor: Updated start scripts to use tsx --env-file, improving environment variable loading.

Model: o4-mini | Prompt Tokens: 834 | Completion Tokens: 754

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your code. I’ve provided some AI-powered suggestions to support you. Keep in mind these are possibilities, not certainties, so choose what fits your needs. You’re in charge—AI is here to help.
Model: o4-mini | Prompt Tokens: 1400 | Completion Tokens: 3425

@github-actions
Copy link

The explicit npx dependency was removed from both pr-review and pr-summary projects, relying on the built-in npx provided by modern npm versions. This streamlines the development setup, reduces redundant package pinning, and aligns with current best practices for tool invocation.

Walkthrough

  • Chore: Removed the npx entry from both package.json files to simplify the dev environment and eliminate unnecessary dependencies.

Model: o4-mini | Prompt Tokens: 402 | Completion Tokens: 368 | Diff Range: e3015d0...704ba45

@daniel-richter daniel-richter merged commit 4ce3fb4 into main Jul 25, 2025
12 of 13 checks passed
@daniel-richter daniel-richter deleted the refactor-scripts branch July 25, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants