-
Notifications
You must be signed in to change notification settings - Fork 3
Update non-major dependencies #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ jobs: | |
| contents: write | ||
| steps: | ||
| - name: Checkout source branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| with: | ||
| ref: ${{ env.SOURCE_BRANCH }} | ||
| path: source-folder | ||
|
|
@@ -66,7 +66,7 @@ jobs: | |
| fi | ||
|
|
||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| path: release-folder | ||
|
|
@@ -102,7 +102,7 @@ jobs: | |
| pull-requests: write | ||
| steps: | ||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| - name: Run the AI-assisted action (PR Summary) | ||
|
Comment on lines
102
to
108
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This checkout-release block is duplicated in multiple jobs. Apply the same DRY principle here by using a composite action or YAML anchor to reduce duplication. And again, pin to |
||
|
|
@@ -123,7 +123,7 @@ jobs: | |
| pull-requests: write | ||
| steps: | ||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| - name: Run the AI-assisted action (PR Review) | ||
|
|
@@ -143,7 +143,7 @@ jobs: | |
| contents: write | ||
| steps: | ||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| - name: Create tags for new version | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ jobs: | |
| path: [pr-summary, pr-review] | ||
| steps: | ||
| - name: Checkout source branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
|
Comment on lines
22
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This checkout step is pinned to a SHA. To simplify your workflow and reduce maintenance, pin to the major version tag (e.g., |
||
| - name: Setup Node | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
|
|
@@ -45,7 +45,7 @@ jobs: | |
| path: [pr-summary, pr-review] | ||
| steps: | ||
| - name: Checkout source branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,16 +31,16 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "9.33.0", | ||
| "@types/node": "22.17.1", | ||
| "@types/node": "22.17.2", | ||
| "@vercel/ncc": "0.38.3", | ||
|
Comment on lines
-34
to
35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The dependency "@types/node": "^22.17.2" |
||
| "eslint": "9.33.0", | ||
| "eslint-plugin-import": "2.32.0", | ||
| "eslint-plugin-sonarjs": "3.0.4", | ||
| "eslint-plugin-unicorn": "60.0.0", | ||
| "prettier": "3.6.2", | ||
| "tsx": "4.20.3", | ||
| "tsx": "4.20.4", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| "typescript": "5.9.2", | ||
| "typescript-eslint": "8.39.0", | ||
| "typescript-eslint": "8.39.1", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly, for "typescript-eslint": "^8.39.1"This ensures future patch-level fixes are pulled in automatically. |
||
| "yaml": "2.8.1" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have several repeated checkout steps pinned to a specific commit SHA (08eba0b27…). This pattern appears multiple times for both source and release branches. Consider refactoring this repetition by extracting a reusable workflow or using YAML anchors/aliases to DRY up the file and make future maintenance easier.
Also, instead of pinning to a full SHA, use a version tag like
actions/checkout@v4. That way you get backward-compatible updates automatically and avoid manual bumps for every minor or patch release. For example: