Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pr-review/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"eslint-plugin-sonarjs": "3.0.4",
"eslint-plugin-unicorn": "60.0.0",
"prettier": "3.6.2",
"tsx": "4.20.4",
"tsx": "4.20.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're pinning "tsx" to an exact version. It's recommended to use caret ranges to allow non-breaking patches to roll in automatically. For example:

{
  "tsx": "^4.20.5"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After bumping "tsx", ensure you update and commit the lockfile so everyone installs the same versions. For example:

npm install
# or if you're using Yarn:
yarn install

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both sub-packages share identical devDependencies (including "tsx"), consider hoisting common deps to the workspace root or using a monorepo tool. This reduces duplication and guarantees consistent versions:

{
  "devDependencies": {
    "tsx": "^4.20.5",
    "typescript": "^5.9.2",
    // ...other shared dependencies
  }
}

"typescript": "5.9.2",
"typescript-eslint": "8.40.0",
"yaml": "2.8.1"
Expand Down
8 changes: 4 additions & 4 deletions pr-summary/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-summary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"eslint-plugin-sonarjs": "3.0.4",
"eslint-plugin-unicorn": "60.0.0",
"prettier": "3.6.2",
"tsx": "4.20.4",
"tsx": "4.20.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're pinning "tsx" to an exact version here as well. Switch to a caret range so that patch updates come through without manual bumps. For example:

{
  "tsx": "^4.20.5"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to regenerate and commit your lockfile after bumping dependencies, ensuring reproducible installs across environments:

npm install
# or with Yarn:
yarn install

"typescript": "5.9.2",
"typescript-eslint": "8.40.0",
"yaml": "2.8.1"
Expand Down