-
Notifications
You must be signed in to change notification settings - Fork 4
Update dependency eslint-plugin-unicorn to v61 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ | |
| "eslint": "9.35.0", | ||
| "eslint-plugin-import": "2.32.0", | ||
| "eslint-plugin-sonarjs": "3.0.5", | ||
| "eslint-plugin-unicorn": "60.0.0", | ||
| "eslint-plugin-unicorn": "61.0.1", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the other package, you’ve updated eslint-plugin-unicorn to an exact version. To improve maintainability and avoid manual syncs across subpackages, switch to a flexible semver range and consider hoisting shared devDependencies into the root. For example: {
"devDependencies": {
"eslint-plugin-unicorn": "^61.0.1"
}
} |
||
| "prettier": "3.6.2", | ||
| "tsx": "4.20.5", | ||
| "typescript": "5.9.2", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re pinning the eslint-plugin-unicorn dependency to an exact version. Pinning makes future patch updates harder to adopt and can lead to drift across packages in a monorepo. Consider using a semver range (e.g., caret) to allow non-breaking updates automatically:
{ "devDependencies": { "eslint-plugin-unicorn": "^61.0.1" } }If you maintain multiple subpackages (like pr-review and pr-summary), centralizing shared devDependencies in the root package.json (via npm/Yarn workspaces or Lerna) can eliminate duplicated version bumps:
{ "private": true, "workspaces": ["pr-review", "pr-summary"], "devDependencies": { "eslint-plugin-unicorn": "^61.0.1" } }