Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pr-review/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"eslint": "9.35.0",
"eslint-plugin-import": "2.32.0",
"eslint-plugin-sonarjs": "3.0.5",
"eslint-plugin-unicorn": "60.0.0",
"eslint-plugin-unicorn": "61.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re pinning the eslint-plugin-unicorn dependency to an exact version. Pinning makes future patch updates harder to adopt and can lead to drift across packages in a monorepo. Consider using a semver range (e.g., caret) to allow non-breaking updates automatically:

{
  "devDependencies": {
    "eslint-plugin-unicorn": "^61.0.1"
  }
}

If you maintain multiple subpackages (like pr-review and pr-summary), centralizing shared devDependencies in the root package.json (via npm/Yarn workspaces or Lerna) can eliminate duplicated version bumps:

{
  "private": true,
  "workspaces": ["pr-review", "pr-summary"],
  "devDependencies": {
    "eslint-plugin-unicorn": "^61.0.1"
  }
}

"prettier": "3.6.2",
"tsx": "4.20.5",
"typescript": "5.9.2",
Expand Down
8 changes: 4 additions & 4 deletions pr-summary/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-summary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"eslint": "9.35.0",
"eslint-plugin-import": "2.32.0",
"eslint-plugin-sonarjs": "3.0.5",
"eslint-plugin-unicorn": "60.0.0",
"eslint-plugin-unicorn": "61.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other package, you’ve updated eslint-plugin-unicorn to an exact version. To improve maintainability and avoid manual syncs across subpackages, switch to a flexible semver range and consider hoisting shared devDependencies into the root. For example:

{
  "devDependencies": {
    "eslint-plugin-unicorn": "^61.0.1"
  }
}

"prettier": "3.6.2",
"tsx": "4.20.5",
"typescript": "5.9.2",
Expand Down