Skip to content

Update dependency axios to v1.12.0 [SECURITY] #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Sep 13, 2025
Merged

Update dependency axios to v1.12.0 [SECURITY] #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pr-review/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-review/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@octokit/webhooks": "13.9.1",
"@sap-ai-sdk/ai-api": "1.18.0",
"@sap-ai-sdk/orchestration": "1.18.0",
"axios": "1.11.0",
"axios": "1.12.0",
Copy link

@github-actions github-actions bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’ve pinned the axios dependency to an exact patch version. To benefit from future patch updates (bug fixes and security patches) without manual bumps, consider using a semver range (e.g., ^1.12.0) instead of an exact version. For example:

{
  "dependencies": {
    "axios": "^1.12.0",
    // …other deps
  }
}

"minimatch": "10.0.3",
"mollitia": "0.2.0",
"octokit": "5.0.3",
Comment on lines 22 to 28
Copy link

@github-actions github-actions bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency lists in both pr-review and pr-summary are identical. To avoid duplication and ensure consistent versions, you could hoist common dependencies to the monorepo root using a workspace setup. For example, in your root package.json:

{
  "private": true,
  "workspaces": [
    "pr-review",
    "pr-summary"
  ],
  "dependencies": {
    "@octokit/webhooks": "13.9.1",
    "@sap-ai-sdk/ai-api": "1.18.0",
    "@sap-ai-sdk/orchestration": "1.18.0",
    "axios": "^1.12.0",
    "minimatch": "10.0.3",
    "mollitia": "0.2.0",
    "octokit": "5.0.3"
  }
}

Expand Down
8 changes: 4 additions & 4 deletions pr-summary/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-summary/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@octokit/webhooks": "13.9.1",
"@sap-ai-sdk/ai-api": "1.18.0",
"@sap-ai-sdk/orchestration": "1.18.0",
"axios": "1.11.0",
"axios": "1.12.0",
Copy link

@github-actions github-actions bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other package, axios is currently locked to 1.12.0. Using a caret range like ^1.12.0 will allow safe patch upgrades and reduce maintenance overhead:

{
  "dependencies": {
    "axios": "^1.12.0",
    // …other deps
  }
}

"minimatch": "10.0.3",
"mollitia": "0.2.0",
"octokit": "5.0.3",
Expand Down