Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-cleanup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
name: Clean up
runs-on: [ubuntu-latest]
steps:
- uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7
- uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using specific commit hashes for actions provides more certainty over the version being used, avoiding unexpected changes due to updates. It's a good practice to update to the latest tagged version regularly which offers stability improvements and new features. Consider using the latest available tag if no specific functionality requires sticking to a particular commit hash.

with:
script: |
github.rest.git.deleteRef({
Comment on lines -17 to 20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor update in the version specification of the GitHub Action. The comment next to the action version should correspond to the actual tag you're using. Ensure the version numbers are always aligned. Consider automation to manage these updates.

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
if: ${{ !startsWith(github.head_ref || github.ref_name, 'release/') }}
steps:
- name: Checkout source branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ env.SOURCE_BRANCH }}
path: source-folder
Comment on lines 18 to 24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When modifying version numbers for actions, ensure comments accurately reflect these versions to avoid confusion. This helps maintain consistency and transparency in the workflow configuration.

Expand All @@ -28,7 +28,7 @@ jobs:
git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com"

- name: Setup Node (PR Summary)
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version-file: source-folder/pr-summary/.node-version
cache: npm
Comment on lines -31 to 34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears npm prune --omit=dev is used. If this command is run automatically after the setup, consider running it explicitly as a separate step to ensure clarity and manageability in your workflow.

Expand All @@ -41,7 +41,7 @@ jobs:
npm prune --omit=dev

- name: Setup Node (PR Review)
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version-file: source-folder/pr-review/.node-version
cache: npm
Expand All @@ -64,7 +64,7 @@ jobs:
fi

- name: Checkout release branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ env.RELEASE_BRANCH }}
path: release-folder
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
if: ${{ github.ref_name != 'main' }}
steps:
- name: Checkout release branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ env.RELEASE_BRANCH }}
- name: Run the AI-assisted action (PR Summary)
Expand All @@ -122,7 +122,7 @@ jobs:
if: ${{ github.ref_name == 'main' }}
steps:
- name: Checkout release branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ env.RELEASE_BRANCH }}
- name: Create tags for new version
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/code-quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
path: [pr-summary, pr-review]
steps:
- name: Checkout source branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Setup Node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
Comment on lines 18 to 25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths pr-summary and pr-review should be relative to the repository's root, make sure they are correct as they affect the checkout operation. Validating paths ensures your workflow steps target the correct directories.

cache: npm
Expand All @@ -41,9 +41,9 @@ jobs:
path: [pr-summary, pr-review]
steps:
- name: Checkout source branch
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Setup Node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
cache: npm
Comment on lines 41 to 49
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like other occurrences, make sure comments and versions remain aligned to simplify version tracking. Consistency in documentation helps in maintaining the workflow over time.

Expand Down
8 changes: 4 additions & 4 deletions pr-review/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"mollitia": "0.2.0",
"octokit": "5.0.3",
"parse-diff": "0.11.1",
"zod": "3.25.74",
"zod": "3.25.75",
"zod-to-json-schema": "3.24.6"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion pr-summary/.node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.16.0
22.17.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js version bump from 22.16.0 to 22.17.0 should be verified against existing code to ensure compatibility. Minor version updates might include performance improvements or bug fixes. Always check the Node.js release notes for any potentially impactful changes.

49 changes: 25 additions & 24 deletions pr-summary/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions pr-summary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
"mollitia": "0.2.0",
"octokit": "5.0.3",
"parse-diff": "0.11.1",
"zod": "3.25.67"
"zod": "3.25.75"
},
"devDependencies": {
"@eslint/js": "9.29.0",
"@types/node": "22.15.32",
"@eslint/js": "9.30.1",
"@types/node": "22.16.0",
"@typescript-eslint/eslint-plugin": "7.18.0",
"@typescript-eslint/parser": "7.18.0",
"@vercel/ncc": "0.38.3",
Expand All @@ -39,10 +39,10 @@
"eslint-config-airbnb-typescript": "18.0.0",
"eslint-config-prettier": "10.1.5",
"eslint-plugin-import": "2.32.0",
"eslint-plugin-prettier": "5.5.0",
"eslint-plugin-sonarjs": "3.0.3",
"eslint-plugin-prettier": "5.5.1",
"eslint-plugin-sonarjs": "3.0.4",
"eslint-plugin-unicorn": "56.0.1",
"prettier": "3.6.0",
"prettier": "3.6.2",
"prettier-eslint": "16.4.2",
"typescript": "5.8.3",
"yaml": "2.8.0"
Expand Down