-
Notifications
You must be signed in to change notification settings - Fork 4
Update non-major dependencies #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| name: Clean up | ||
| runs-on: [ubuntu-latest] | ||
| steps: | ||
| - uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7 | ||
| - uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 | ||
| with: | ||
| script: | | ||
| github.rest.git.deleteRef({ | ||
|
Comment on lines
-17
to
20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a minor update in the version specification of the GitHub Action. The comment next to the action version should correspond to the actual tag you're using. Ensure the version numbers are always aligned. Consider automation to manage these updates. |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |
| if: ${{ !startsWith(github.head_ref || github.ref_name, 'release/') }} | ||
| steps: | ||
| - name: Checkout source branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: ${{ env.SOURCE_BRANCH }} | ||
| path: source-folder | ||
|
Comment on lines
18
to
24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When modifying version numbers for actions, ensure comments accurately reflect these versions to avoid confusion. This helps maintain consistency and transparency in the workflow configuration. |
||
|
|
@@ -28,7 +28,7 @@ jobs: | |
| git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com" | ||
|
|
||
| - name: Setup Node (PR Summary) | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: source-folder/pr-summary/.node-version | ||
| cache: npm | ||
|
Comment on lines
-31
to
34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It appears |
||
|
|
@@ -41,7 +41,7 @@ jobs: | |
| npm prune --omit=dev | ||
|
|
||
| - name: Setup Node (PR Review) | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: source-folder/pr-review/.node-version | ||
| cache: npm | ||
|
|
@@ -64,7 +64,7 @@ jobs: | |
| fi | ||
|
|
||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| path: release-folder | ||
|
|
@@ -97,7 +97,7 @@ jobs: | |
| if: ${{ github.ref_name != 'main' }} | ||
| steps: | ||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| - name: Run the AI-assisted action (PR Summary) | ||
|
|
@@ -122,7 +122,7 @@ jobs: | |
| if: ${{ github.ref_name == 'main' }} | ||
| steps: | ||
| - name: Checkout release branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: ${{ env.RELEASE_BRANCH }} | ||
| - name: Create tags for new version | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,9 +18,9 @@ jobs: | |
| path: [pr-summary, pr-review] | ||
| steps: | ||
| - name: Checkout source branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version: 18 | ||
|
Comment on lines
18
to
25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The paths |
||
| cache: npm | ||
|
|
@@ -41,9 +41,9 @@ jobs: | |
| path: [pr-summary, pr-review] | ||
| steps: | ||
| - name: Checkout source branch | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version: 18 | ||
| cache: npm | ||
|
Comment on lines
41
to
49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just like other occurrences, make sure comments and versions remain aligned to simplify version tracking. Consistency in documentation helps in maintaining the workflow over time. |
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 22.16.0 | ||
| 22.17.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Node.js version bump from 22.16.0 to 22.17.0 should be verified against existing code to ensure compatibility. Minor version updates might include performance improvements or bug fixes. Always check the Node.js release notes for any potentially impactful changes. |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using specific commit hashes for actions provides more certainty over the version being used, avoiding unexpected changes due to updates. It's a good practice to update to the latest tagged version regularly which offers stability improvements and new features. Consider using the latest available tag if no specific functionality requires sticking to a particular commit hash.