Skip to content

chore: [Orchestration] Improve Streaming Sample Code #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jonas-Isr merged 4 commits into from
Dec 20, 2024
Merged

chore: [Orchestration] Improve Streaming Sample Code #243

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
641692f
Update Streaming test
MatKuhr Dec 18, 2024
c819f0e
Merge branch 'main' into fix/streaming-e2e-test
MatKuhr Dec 19, 2024
e36dbed
Merge with changes from main
MatKuhr Dec 19, 2024
f084533
Update
MatKuhr Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ ResponseEntity<String> completion(
@GetMapping("/streamChatCompletion")
@Nonnull
ResponseEntity<ResponseBodyEmitter> streamChatCompletion() {
return service.streamChatCompletion(100);
return service.streamChatCompletion();
}

/**
Expand Down
6 changes: 2 additions & 4 deletions sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,10 @@ public OrchestrationChatResponse grounding(@Nonnull final String groundingInput)
* @return the emitter that streams the assistant message response
*/
@Nonnull
public ResponseEntity<ResponseBodyEmitter> streamChatCompletion(final int numberOfFibonacci) {
public ResponseEntity<ResponseBodyEmitter> streamChatCompletion() {
final var prompt =
new OrchestrationPrompt(
"Can you give me the first "
+ numberOfFibonacci
+ " numbers of the Fibonacci sequence?");
"Please create a small story about developing a software project with around 700 words.");
Copy link
Contributor

@newtork newtork Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Minor/Comment)

For sake of sample code quality and "real world" application, I would probably still prefer a service method parameter.

Suggested change
"Please create a small story about developing a software project with around 700 words.");
"Please create a small story about "+topic+" with around 700 words.");

final var stream = client.streamChatCompletion(prompt, config);

final var emitter = new ResponseBodyEmitter();
Expand Down
Loading