Refactor OpenAiController in sample app #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Isr
changed the title
newtork
reviewed
Dec 19, 2024
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Dec 19, 2024
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java
Outdated
Show resolved
Hide resolved
# Conflicts: # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java
newtork
reviewed
Dec 20, 2024
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Show resolved
Hide resolved
newtork
previously approved these changes
Dec 20, 2024
jjtang1985
changed the title
newtork
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#132
Before, in the sample app we simply returned our Java classes in the controller and let them be deserialised to be displayed. This stopped working properly at some point for the
Orchestrationendpoints (see linked issue above). In order to circumvent this, we decided to not rely on the deserialisation and also split up the business logic of the app into a dedicated service class.This PR does this for the
OpenAiController.There is a related PR (that is already merged) for
OrchestrationController.Feature scope:
OpenAiControllerto newly addedOpenAiService.Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated