chore: [DevOps] PR Title Linter #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Jan 13, 2025
newtork
reviewed
Jan 13, 2025
Comment on lines
+3
to
+8
| on: | ||
| pull_request_target: | ||
| types: | ||
| - opened | ||
| - edited | ||
| - synchronize |
Contributor
There was a problem hiding this comment.
(Comment/Opinion)
I didn't expect this syntax to be mandatory.
- It may discourage future, external contributors.
- It may break current and future automated PRs.
It's not possible to make this more like a warning/notification right?
Member
Author
There was a problem hiding this comment.
more like a warning
No, at least not per the docs. I checked that it works with Dependabot, but Release PRs would currently fail. Updated the script ✅. For external contributors it should be fine, because it is easy to fix and only occurs after a PR is already raised, i.e. when most of the work is already done.
CharlesDuboisSAP
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples which are allowed:
chore: [DevOps] PR Title Linterchore: [DevOps] pr title linterchore: PR Title LinterExamples which are not allowed:
PR Title Linter[DevOps] PR Title Linterchore: [Foo] PR Title LinterTested on my fork