chore [Orchestration]: Update of available model list #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
requested changes
Jan 15, 2025
Comment on lines
16
to
23
| public static final OpenAiModel DALL_E_3 = new OpenAiModel("dall-e-3", null); | ||
|
|
||
| /** Azure OpenAI GPT-3.5 Turbo chat completions model */ | ||
| public static final OpenAiModel GPT_35_TURBO = new OpenAiModel("gpt-35-turbo", null); | ||
|
|
||
| /** Azure OpenAI GPT-3.5 Turbo chat completions model */ | ||
| public static final OpenAiModel GPT_35_TURBO_1025 = new OpenAiModel("gpt-35-turbo-0125", null); | ||
| public static final OpenAiModel GPT_35_TURBO_0125 = new OpenAiModel("gpt-35-turbo-0125", null); |
Contributor
There was a problem hiding this comment.
This is a breaking change. It has to stay. Can be optionally @Deprecated
Contributor
Author
There was a problem hiding this comment.
Ok. Just for my understanding, basically any change/deletion in naming or type of variables, functions, classes etc is always a breaking change, right?
Contributor
There was a problem hiding this comment.
Yes when it's public
This reverts commit 4a656fb.
CharlesDuboisSAP
approved these changes
Jan 16, 2025
TillK17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#139
Updated model list for Orchestration (new
amazon--novamodels andgpt-35-turbo-0125) and OpenAI client (deletion ofdall-e-3). Added link and disclaimer for possible outdatedness to JavaDoc of both classes.Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKRelease notes updated