feat: Orchestration image support #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Isr
commented
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/Message.java
Outdated
Show resolved
Hide resolved
Jonas-Isr
commented
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Show resolved
Hide resolved
Jonas-Isr
commented
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Outdated
Show resolved
Hide resolved
Jonas-Isr
commented
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Outdated
Show resolved
Hide resolved
Jonas-Isr
commented
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/MessageContent.java
Outdated
Show resolved
Hide resolved
Jonas-Isr
commented
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/MessageContentMulti.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
newtork
reviewed
Jan 23, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Outdated
Show resolved
Hide resolved
Jonas-Isr
commented
Jan 28, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/Message.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 28, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 28, 2025
Comment on lines
76
to
77
| default ChatMessagesInner createChatMessage() { | ||
| if (this.getContent() instanceof MessageContentSingle) { | ||
| return ChatMessage.create().role(role()).content(content()); | ||
| } else if (this.getContent() instanceof MessageContentMulti mCMulti) { | ||
| if (this.content() instanceof MessageContentSingle) { |
Contributor
There was a problem hiding this comment.
(Minor/Opinion)
I think it's a mistake to have this method on public API.
Maybe we could address this in another PR.
newtork
reviewed
Jan 28, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/SystemMessage.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
newtork
reviewed
Jan 28, 2025
Contributor
There was a problem hiding this comment.
I want to explain my assumptions for convenience API behavior / contract.
-
For request:
- the user will only use public constructors and factory methods for easy instantiation.
- low API hierarchy requirement; we'll try to avoid users to define helper classes.
- strict value checking on design time; only allow what's aligned in spec.
-
For responses:
- developer uses public accessors.
- while casting may be necessary, let's try to minimalize the effort.
- hierarchy can be high as long as it's reasonable.
- loose value checking; whatever is sent back from server can be read with our API.
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/MessageContent.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/MessageContent.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/MessageContent.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/ContentItem.java
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/ImageItem.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/Message.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/Message.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/MessageContent.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 6, 2025
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Feb 7, 2025
newtork
reviewed
Feb 7, 2025
newtork
previously approved these changes
Feb 9, 2025
# Conflicts: # docs/release-notes/release_notes.md
newtork
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#152.
We want to support using images and prompts with multiple text messages as input for Orchestration.
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDK