Skip to content

Conversation

@TillK17
Copy link
Contributor

@TillK17 TillK17 commented Feb 5, 2025

Context

AI/ai-sdk-java-backlog#187

Added note to PR checklist for release process. Updated GitHub Releases notes for v1.0.0 and 1.2.0.

Feature scope:

  • Add a note to the PR checklist for release on adapting GH release notes to the pretty format
  • The release notes of v1.2.0 is also improved to follow the same structure

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@TillK17 TillK17 added the please-review Request to review a pull-request label Feb 5, 2025
@Jonas-Isr
Copy link
Member

I might have misunderstood the assignment, but I assumed the reminder should be put into the PR that is opened by the prepare-release workflow, i.e., here?

newtork
newtork previously requested changes Feb 5, 2025
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change correct template.

@TillK17 TillK17 enabled auto-merge (squash) February 6, 2025 10:11
@TillK17 TillK17 disabled auto-merge February 6, 2025 10:11
@TillK17 TillK17 merged commit 8704dea into main Feb 6, 2025
3 of 4 checks passed
@TillK17 TillK17 deleted the PR-template-update branch February 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants